Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render pass lambda captures storing outdated material variables #10

Open
cjhoward opened this issue Dec 22, 2023 · 0 comments
Open

Render pass lambda captures storing outdated material variables #10

cjhoward opened this issue Dec 22, 2023 · 0 comments
Assignees
Labels

Comments

@cjhoward
Copy link
Member

cjhoward commented Dec 22, 2023

Currently some render passes, such as the material pass, capture material variables as shared pointers in lambdas. However, sometimes a material's variables are changed or a material with the same hash but different variables is created, causing outdated material parameters to be passed to a shader.

The whole model of storing shared pointers to material variables in lambda captures is messy, confusing, and leads to difficult-to-track bugs. The material variable and shader variable interfaces need to be redesigned to be less bug-prone and easier to use.

Also take into consideration that the individual shader uniform model should be phased out in favor of uniform buffer objects.

@cjhoward cjhoward added this to the 0.1.0 "Harvesters" milestone Jan 25, 2025
@cjhoward cjhoward self-assigned this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant