You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks that calculation of spot resolution is wrong.
The correct formula is d = lambda / 2 / sin(theta), while the code calculates lambda / sin(2 theta).
The variable "sintheta" is actually sin(2 theta).
For small theta, sin(2 theta) is close to 2 sin(theta), so the error is not very big. Is this intended approximation?
It looks that calculation of spot resolution is wrong.
The correct formula is d = lambda / 2 / sin(theta), while the code calculates lambda / sin(2 theta).
The variable "sintheta" is actually sin(2 theta).
For small theta, sin(2 theta) is close to 2 sin(theta), so the error is not very big. Is this intended approximation?
https://github.com/antonbarty/cheetah/blob/master/source/libcheetah/src/peakfinders.cpp#L200
The text was updated successfully, but these errors were encountered: