Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution calculation is wrong #23

Open
biochem-fan opened this issue Oct 19, 2015 · 0 comments
Open

Resolution calculation is wrong #23

biochem-fan opened this issue Oct 19, 2015 · 0 comments

Comments

@biochem-fan
Copy link

It looks that calculation of spot resolution is wrong.
The correct formula is d = lambda / 2 / sin(theta), while the code calculates lambda / sin(2 theta).
The variable "sintheta" is actually sin(2 theta).

For small theta, sin(2 theta) is close to 2 sin(theta), so the error is not very big. Is this intended approximation?

https://github.com/antonbarty/cheetah/blob/master/source/libcheetah/src/peakfinders.cpp#L200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant