Skip to content

Commit d08a6d1

Browse files
committed
Make click handlers in EmailView more semantic
1 parent fa9ba4f commit d08a6d1

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

05-email-view/src/components/EmailView.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default class EmailView extends React.Component {
77
onClose: React.PropTypes.func.isRequired
88
}
99

10-
_handleCloseClick(e) {
10+
_handleClose(e) {
1111
e.stopPropagation();
1212
this.props.onClose();
1313
}
@@ -24,7 +24,7 @@ export default class EmailView extends React.Component {
2424
<h2>From: <a href={`mailto:${from}`}>{from}</a></h2>
2525
<h3>{date}</h3>
2626
<div dangerouslySetInnerHTML={rawMessage} />
27-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
27+
<button onClick={this._handleClose.bind(this)}>Close</button>
2828
</div>
2929
);
3030
}

06-email-form/src/components/EmailView.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default class EmailView extends React.Component {
77
onClose: React.PropTypes.func.isRequired
88
}
99

10-
_handleCloseClick(e) {
10+
_handleClose(e) {
1111
e.stopPropagation();
1212
this.props.onClose();
1313
}
@@ -24,7 +24,7 @@ export default class EmailView extends React.Component {
2424
<h2>From: <a href={`mailto:${from}`}>{from}</a></h2>
2525
<h3>{date}</h3>
2626
<div dangerouslySetInnerHTML={rawMessage} />
27-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
27+
<button onClick={this._handleClose.bind(this)}>Close</button>
2828
</div>
2929
);
3030
}

07-submit-email-form/src/components/EmailView.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default class EmailView extends React.Component {
77
onClose: React.PropTypes.func.isRequired
88
}
99

10-
_handleCloseClick(e) {
10+
_handleClose(e) {
1111
e.stopPropagation();
1212
this.props.onClose();
1313
}
@@ -24,7 +24,7 @@ export default class EmailView extends React.Component {
2424
<h2>From: <a href={`mailto:${from}`}>{from}</a></h2>
2525
<h3>{date}</h3>
2626
<div dangerouslySetInnerHTML={rawMessage} />
27-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
27+
<button onClick={this._handleClose.bind(this)}>Close</button>
2828
</div>
2929
);
3030
}

08-optimistic-updating/src/components/EmailView.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default class EmailView extends React.Component {
77
onClose: React.PropTypes.func.isRequired
88
}
99

10-
_handleCloseClick(e) {
10+
_handleClose(e) {
1111
e.stopPropagation();
1212
this.props.onClose();
1313
}
@@ -24,7 +24,7 @@ export default class EmailView extends React.Component {
2424
<h2>From: <a href={`mailto:${from}`}>{from}</a></h2>
2525
<h3>{date}</h3>
2626
<div dangerouslySetInnerHTML={rawMessage} />
27-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
27+
<button onClick={this._handleClose.bind(this)}>Close</button>
2828
</div>
2929
);
3030
}

09-delete-email/src/components/EmailView.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ export default class EmailView extends React.Component {
88
onDelete: React.PropTypes.func.isRequired
99
}
1010

11-
_handleCloseClick(e) {
11+
_handleClose(e) {
1212
e.stopPropagation();
1313
this.props.onClose();
1414
}
1515

16-
_handleDeleteClick(e) {
16+
_handleDelete(e) {
1717
e.stopPropagation();
1818
this.props.onDelete();
1919
}
@@ -30,8 +30,8 @@ export default class EmailView extends React.Component {
3030
<h2>From: <a href={`mailto:${from}`}>{from}</a></h2>
3131
<h3>{date}</h3>
3232
<div dangerouslySetInnerHTML={rawMessage} />
33-
<button onClick={this._handleDeleteClick.bind(this)}>Delete</button>
34-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
33+
<button onClick={this._handleDelete.bind(this)}>Delete</button>
34+
<button onClick={this._handleClose.bind(this)}>Close</button>
3535
</div>
3636
);
3737
}

10-mark-unread/src/components/EmailView.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,25 @@ export default class EmailView extends React.Component {
1111
onMarkRead: React.PropTypes.func
1212
}
1313

14-
_handleCloseClick(e) {
14+
_handleClose(e) {
1515
e.stopPropagation();
1616
this.props.onClose();
1717
}
1818

19-
_handleDeleteClick(e) {
19+
_handleDelete(e) {
2020
e.stopPropagation();
2121
this.props.onDelete();
2222
}
2323

24-
_handleMarkUnreadClick(e) {
24+
_handleMarkUnread(e) {
2525
e.stopPropagation();
2626

2727
if (this.props.onMarkUnread) {
2828
this.props.onMarkUnread();
2929
}
3030
}
3131

32-
_handleMarkReadClick(e) {
32+
_handleMarkRead(e) {
3333
e.stopPropagation();
3434

3535
if (this.props.onMarkRead) {
@@ -43,8 +43,8 @@ export default class EmailView extends React.Component {
4343
} = this.props;
4444
let rawMessage = {__html: message};
4545
let markUnreadReadButton = unread
46-
? (<button onClick={this._handleMarkReadClick.bind(this)}>Mark Read</button>)
47-
: (<button onClick={this._handleMarkUnreadClick.bind(this)}>Mark Unread</button>);
46+
? (<button onClick={this._handleMarkRead.bind(this)}>Mark Read</button>)
47+
: (<button onClick={this._handleMarkUnread.bind(this)}>Mark Unread</button>);
4848

4949
return (
5050
<div>
@@ -53,8 +53,8 @@ export default class EmailView extends React.Component {
5353
<h3>{date}</h3>
5454
<div dangerouslySetInnerHTML={rawMessage} />
5555
{markUnreadReadButton}
56-
<button onClick={this._handleDeleteClick.bind(this)}>Delete</button>
57-
<button onClick={this._handleCloseClick.bind(this)}>Close</button>
56+
<button onClick={this._handleDelete.bind(this)}>Delete</button>
57+
<button onClick={this._handleClose.bind(this)}>Close</button>
5858
</div>
5959
);
6060
}

0 commit comments

Comments
 (0)