Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of *.zip in tests cases #46449

Open
1 of 2 tasks
Lee-W opened this issue Feb 5, 2025 · 1 comment · May be fixed by #46459
Open
1 of 2 tasks

Get rid of *.zip in tests cases #46449

Lee-W opened this issue Feb 5, 2025 · 1 comment · May be fixed by #46459
Assignees
@josix
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools good first issue kind:feature Feature Requests

Comments

@Lee-W
Copy link
Member

Lee-W commented Feb 5, 2025

Description

We should generate the zip file in our test case (i.e., include the files we want to zip but not the zip file itself) and then do the test instead of uploading it to the repo. Currently, we have the following 2 zip files.

  • tests/dags/test_dag_warnings.zip
  • tests/dags/test_zip.zip

In addition to it, we should have a pre-commit to avoid someone from commit a zip file.

Use case/motivation

zip files are hard to review and could incur security issues.

Related issues

#46231 (comment)

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@dosubot dosubot bot added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Feb 5, 2025
@josix
Copy link
Contributor

josix commented Feb 5, 2025

I can take this one.

@SaumilPatel03 SaumilPatel03 linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josix josix

Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pre-commit hook to avoid committing zip file SaumilPatel03/airflow
2 participants
@Lee-W @josix