Update pre-commit hook to avoid committing zip file #46459
+86
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a link to PEP 668 in the virtual environment section
SaumilPatel03
requested review from
potiuk,
ashb and
jedcunningham
as code owners
Add pre-commit hook to prevent committing .zip files
SaumilPatel03
force-pushed
the
Check_zip_file
branch
from
3b87b57 to
9e7ae7f
Compare
potiuk
requested changes
Feb 5, 2025
There was a problem hiding this comment.
- There are unrelated changes in there - describing documentation about development environment. If you want to submit it, you should have separate PR about it.
- I think such precommit makes no sense. It can be done by just setting .gitignore at top level to include .zip files - there is absolutely no need to have pre-commit for that and it is harmful actually. We might want to commit some .zip files for tests for example so I don't even think it is a good idea in the first place
|
But right now we have zip files |
Yes. But I believe we do not need pre-commit for that - .gitignore should be enough. And even if we want to have .zip check the precommit should be just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong: Committed ZIP files are hard to review and can pose security risks.
What was changed: added a Python pre-commit hook to prevent their accidental commit.
closes: #46449