Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow configuring apiVersion in Ingress Class resource #698

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: allow configuring apiVersion in Ingress Class resource #698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1025eab
fix: allow configuring apiVersion in Ingress Class resource
Revolyssup Jan 15, 2024
086b412
apply suggestions
Revolyssup Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/apisix-ingress-controller/templates/ingress-class.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{{ if (eq .Values.config.kubernetes.ingressVersion "") }}
apiVersion: networking.k8s.io/v1
{{- else }}
apiVersion: {{ .Values.config.kubernetes.ingressVersion }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/apisix-ingress-controller/blob/master/conf/config-default.yaml#L72-L74

Are you sure you can use it directly?
networking/v1beta1 != networking.k8s.io/v1beta1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

{{- end }}
kind: IngressClass
metadata:
name: {{ .Values.config.kubernetes.ingressClass | quote }}
Expand Down
Loading