Skip to content

Commit 1498038

Browse files
authored
fix: loading fails when plugin configuration is empty (#45)
1 parent 5762925 commit 1498038

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

apisix/runner/http/request.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ def set_config(self, key: str, value: str):
333333
:param value:
334334
:return:
335335
"""
336-
if key and value:
336+
if key:
337337
self.__configs[key] = value
338338
return True
339339
return False

tests/runner/http/test_request.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ def test_request_handler():
107107
assert req.set_headers({default_key: default_val})
108108
assert req.get_headers() == {default_key: default_val}
109109

110-
assert not req.set_config(default_key, default_empty_str)
110+
assert not req.set_config(default_empty_str, default_empty_str)
111+
assert req.set_config(default_key, default_empty_str)
111112
assert req.set_config(default_key, default_val)
112113
assert req.get_config(default_key) == default_val
113114

0 commit comments

Comments
 (0)