Skip to content

Commit 11e73a8

Browse files
authored
Increase CMake minimum version, move requirement (#422)
This is a very minor 'quality of life' improvement to `linesplitter` as `cmake` nags about the minimum requirement being after (rather than before) the main project declaration, and increasing the version (which I understand you may not want to increase by as much) silences the TIMESTAMP nag. Feel free to adjust or ignore, I just liked the quieter build.
1 parent 1751bdd commit 11e73a8

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

examples/linesplitter/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,17 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
project(linesplitter)
1918
cmake_minimum_required(VERSION 3.14)
19+
project(linesplitter)
2020

2121
set(CMAKE_CXX_STANDARD 11)
2222

23+
# Avoids a warning about timestamps on downloaded files (prefer new policy
24+
# if available))
25+
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.23")
26+
cmake_policy(SET CMP0135 NEW)
27+
endif()
28+
2329
include(FetchContent)
2430

2531
fetchcontent_declare(nanoarrow

0 commit comments

Comments
 (0)