Skip to content

Commit 1640245

Browse files
authored
chore(dev/benchmarks): Update benchmarks build for latest CMake changes (#730)
After #719, `target_link_libraries(... nanoarrow)` must be `target_link_libraries(... nanoarrow::nanoarrow)` and I'd forgotten to update the benchmarks build.
1 parent ea05d76 commit 1640245

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

dev/benchmarks/CMakeLists.txt

+15-3
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,19 @@ elseif(NOT "${NANOARROW_BENCHMARK_SOURCE_URL}" STREQUAL "")
7171
endif()
7272
endif()
7373

74+
# nanoarrow >= 0.7 uses an alias target (or explicit _static/_shared)
75+
if(NOT TARGET nanoarrow::nanoarrow)
76+
message(STATUS "Adding nanoarrow::nanoarrow alias target")
77+
add_library(nanoarrow::nanoarrow ALIAS nanoarrow)
78+
endif()
79+
80+
if(NOT TARGET nanoarrow::nanoarrow_ipc)
81+
message(STATUS "Adding nanoarrow::nanoarrow_ipc alias target")
82+
add_library(nanoarrow::nanoarrow_ipc ALIAS nanoarrow_ipc)
83+
endif()
84+
7485
# Check that either the parent scope or this CMakeLists.txt defines a nanoarrow target
75-
if(NOT TARGET nanoarrow OR NOT TARGET nanoarrow_ipc)
86+
if(NOT TARGET nanoarrow::nanoarrow OR NOT TARGET nanoarrow::nanoarrow_ipc)
7687
message(FATAL_ERROR "nanoarrow or nanoarrow_ipc target not found (missing -DNANOARROW_BENCHMARK_SOURCE_URL option?)"
7788
)
7889
endif()
@@ -92,8 +103,9 @@ enable_testing()
92103

93104
foreach(ITEM schema;array;ipc)
94105
add_executable(${ITEM}_benchmark "c/${ITEM}_benchmark.cc")
95-
target_link_libraries(${ITEM}_benchmark PRIVATE nanoarrow nanoarrow_ipc
96-
benchmark::benchmark_main)
106+
target_link_libraries(${ITEM}_benchmark
107+
PRIVATE nanoarrow::nanoarrow nanoarrow::nanoarrow_ipc
108+
benchmark::benchmark_main)
97109
add_test(NAME ${ITEM}_benchmark COMMAND ${ITEM}_benchmark
98110
--benchmark_out=${ITEM}_benchmark.json)
99111
set_tests_properties(${ITEM}_benchmark PROPERTIES WORKING_DIRECTORY

0 commit comments

Comments
 (0)