fix bad json error

apache · Nov 30, 2023 · abb0253 · abb0253
1 parent c953421
commit abb0253
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/nanoarrow/nanoarrow_testing.hpp b/src/nanoarrow/nanoarrow_testing.hpp
@@ -714,7 +714,8 @@ class TestingJSONReader {
       ArrowArrayStreamMove(stream.get(), out);
       return NANOARROW_OK;
     } catch (json::exception& e) {
-      ArrowErrorSet(error, "Exception in TestingJSONReader::ReadBatch(): %s", e.what());
+      ArrowErrorSet(error, "Exception in TestingJSONReader::ReadDataFile(): %s",
+                    e.what());
       return EINVAL;
     }
   }

diff --git a/src/nanoarrow/nanoarrow_testing_test.cc b/src/nanoarrow/nanoarrow_testing_test.cc
@@ -774,6 +774,9 @@ TEST(NanoarrowTestingTest, NanoarrowTestingTestRoundtripDataFile) {
   std::stringstream data_file_json_roundtrip;
   ASSERT_EQ(writer.WriteDataFile(data_file_json_roundtrip, stream.get()), NANOARROW_OK);
   EXPECT_EQ(data_file_json_roundtrip.str(), data_file_json);
+
+  // Also test error for invalid JSON
+  ASSERT_EQ(reader.ReadDataFile("{", stream.get()), EINVAL);
 }
 
 TEST(NanoarrowTestingTest, NanoarrowTestingTestReadBatch) {