Skip to content

Commit d6eb52b

Browse files
authored
refactor: Remove CMake requirement from Meson IPC config (#522)
Follow up to #483
1 parent f6a6b40 commit d6eb52b

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

ci/scripts/build-with-meson.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ function main() {
6666
pushd "${SANDBOX_DIR}"
6767

6868
show_header "Run test suite"
69-
meson configure -Dtests=true -Db_coverage=true
69+
meson configure -Dtests=true -Db_coverage=true -Dipc=true
7070
meson compile
7171
meson test --wrap='valgrind --track-origins=yes --leak-check=full' --print-errorlogs
7272

src/nanoarrow/meson.build

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ nanoarrow_dep = declare_dependency(include_directories: [curdir, incdir],
6565
link_with: nanoarrow_lib)
6666

6767
if get_option('ipc')
68-
cmake = import('cmake')
69-
cmake_opts = cmake.subproject_options()
70-
cmake_opts.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': true})
71-
flatcc_subproj = cmake.subproject('flatcc', options: cmake_opts)
72-
flatcc_dep = flatcc_subproj.dependency('flatccrt')
68+
flatcc_dep = dependency('flatcc')
7369

7470
nanoarrow_ipc_lib = build_target(
7571
'nanoarrow_ipc',
@@ -172,9 +168,14 @@ if get_option('tests')
172168
ipc_test_files = {
173169
'nanoarrow-ipc-decoder': {
174170
'deps': [nanoarrow_ipc_dep, arrow_dep, gtest_dep],
171+
'timeout': 30,
175172
},
176173
'nanoarrow-ipc-reader': {
177174
'deps': [nanoarrow_ipc_dep, arrow_dep, gtest_dep],
175+
# the ipc reader test can take longer when executed
176+
# under valgrind, hence the increased timeout
177+
'timeout': 90,
178+
178179
},
179180
'nanoarrow-ipc-files': {
180181
'deps': [
@@ -184,9 +185,11 @@ if get_option('tests')
184185
gtest_dep,
185186
nlohmann_json_dep
186187
],
188+
'timeout': 30,
187189
},
188190
'nanoarrow-ipc-hpp': {
189191
'deps': [nanoarrow_ipc_dep, gtest_dep],
192+
'timeout': 30,
190193
},
191194
}
192195

@@ -196,7 +199,7 @@ if get_option('tests')
196199
name.replace('-', '_') + '_test.cc',
197200
dependencies: config['deps']
198201
)
199-
test(name, exc)
202+
test(name, exc, timeout: config['timeout'])
200203
endforeach
201204
endif
202205
endif

subprojects/flatcc.wrap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ source_url = https://github.com/dvidelabs/flatcc/archive/refs/tags/v0.6.1.tar.gz
2121
source_filename = flatcc-0.6.1.tar.gz
2222
source_hash = 2533c2f1061498499f15acc7e0937dcf35bc68e685d237325124ae0d6c600c2b
2323
patch_directory = flatcc
24+
25+
[provide]
26+
flatcc = flatcc_dep

0 commit comments

Comments
 (0)