add async or sync for :ledger metadata index's rocksdb write #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
Vanlightly,
eolivelli,
nicoloboschi,
hangc0276,
merlimat and
zymap
eolivelli
requested changes
Aug 19, 2022
| try { | ||
| keyWrapper.set(STORAGE_FLAGS); | ||
| newFlagsWrapper.set(newFlags); | ||
| synchronized (ledgersDb) { |
There was a problem hiding this comment.
it seems to be that synchronisation around ledgersDb is not consistent.
sometimes we don't access the variable that way.
I wonder why spotbugs does not complain
There was a problem hiding this comment.
This logic has not been updated, and the code to move according to #2936
It doesn't seem to be a problem, or if I modify synchronized to the method, I will make a unified correction to the historical code. @eolivelli
added 3 commits
August 19, 2022 17:36
StevenLuMT
requested review from
eolivelli
and removed request for
merlimat,
Vanlightly,
hangc0276,
nicoloboschi and
zymap
|
reopen the pr, run the new workflow |
dlg99
approved these changes
Sep 20, 2022
|
Temporarily close first, and reopen after improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
bookie flush mainly composed of three pieces:
1. flush-entrylog: it's flushing entrylog
2. flush-locations-index: it's flushing entrly location index, use sync mode to flush
3. flush-ledger-index: it's flushing ledger metadata index, this index(LedgerMetadataIndex) use async mode to flush
sync is different from async：
sync mode:
1. create a batch;
5. add msg to the batch
6. call method(batch.flush) to flush the batch
async mode:
1. just call method(sync) to write the data
2. the rocksdb server will be timed to flush the data
Changes