Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extends fix of CAMEL-21713: endpoint url override to aws-secret-manager #17060

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

JiriOndrusek
Copy link
Contributor

follows #17052

The override endpoint url is missing also for CloudTrailClient.
The localstack cloudtrail lookup is not implemented yet, therefore endpoint url override cannot be used now in this case. But I think that it is better to have the code prepared for the future.

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus force-pushed the aws-secret-manager-better-fix branch from a8bbfdc to 275a33c Compare February 5, 2025 08:34
@davsclaus davsclaus force-pushed the aws-secret-manager-better-fix branch from 275a33c to b9b6b8f Compare February 5, 2025 09:38
@davsclaus davsclaus merged commit 3d54f22 into apache:main Feb 5, 2025
4 checks passed
@davsclaus
Copy link
Contributor

is this something that is good to backport to 4.8.x branch ?

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Feb 5, 2025

is this something that is good to backport to 4.8.x branch ?

It's not required for backport to 4.8.x from my POV. Very simple workaround is to add parameters with credentials with "fake" values.
On the other hand the fix is so small, that it should be save to backport and it should make users happier when using azure-key-vault with identity.

the change is for testing only, therefore there is no need to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants