-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-21715: Fix test-jar dependencies #17071
base: main
Are you sure you want to change the base?
CAMEL-21715: Fix test-jar dependencies #17071
Conversation
- Since we have been moving some classes in the test-infra-* modules from src/test/java to src/main/java we need to explicitly depend on both test-jar and normal typed dependencies - Maven will figure it out but IDEs such as IntelliJ raise compile errors - Explicitly add dependency to test-infra-* modules to avoid compile errors in IntelliJ due to test-jar typed dependencies
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
so we need both test and test-jar dependencies ? |
yes, seems only a few classes have been moved from src/test/java to /src/main/java |
this is only for IDEs like IntelliJ because Maven itself will figure out the transitive dependency when the |
The test jar one is enough since the following plugin https://github.com/apache/camel/blob/main/test-infra/pom.xml#L108 will assembly both test and main classes into the test-jar |
@Croway ah was not ware of this. but why is IntelliJ showing those compile errors then? Is the assembly disabled when using the |
oh, this is strange, actually I didn't notice it in intellij |
no, it is not disabled with -Dquickly option |
am I the only one seeing the compile errors in the IDE? for instance when opening |
Description
Target
main
branch)Fixes CAMEL-21715
Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally from root folder and I have committed all auto-generated changes.