Skip to content

Commit 989a593

Browse files
nipunsharma12hsluoyz
authored andcommitted
feat(close-connections): Add try-with-resources for connections (#94)
1 parent 4950c38 commit 989a593

2 files changed

Lines changed: 161 additions & 166 deletions

File tree

src/main/java/org/casbin/adapter/JDBCAdapter.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,9 @@ public boolean isFiltered() {
124124
*/
125125
private void loadFilteredPolicyFile(Model model, Filter filter, Helper.loadPolicyLineHandler<String, Model> handler) throws CasbinAdapterException {
126126
Failsafe.with(retryPolicy).run(ctx -> {
127-
if (ctx.isRetry()) {
128-
retry(ctx);
129-
}
130-
try (Statement stmt = conn.createStatement();
131-
ResultSet rSet = stmt.executeQuery(renderActualSql("SELECT * FROM casbin_rule"))) {
127+
try (Connection conn = dataSource.getConnection();
128+
Statement stmt = conn.createStatement();
129+
ResultSet rSet = stmt.executeQuery(renderActualSql("SELECT * FROM casbin_rule"))) {
132130
ResultSetMetaData rData = rSet.getMetaData();
133131
while (rSet.next()) {
134132
CasbinRule line = new CasbinRule();

0 commit comments

Comments
 (0)