Skip to content

Commit 8e59e52

Browse files
authored
refactor: Move CDVURLSchemeHandler to private API (#1477)
This is only used by the WKWebView plugin, and there's no way to do anything meaningful with it as public API, so it probably shouldn't be public API.
1 parent e327997 commit 8e59e52

File tree

5 files changed

+14
-15
lines changed

5 files changed

+14
-15
lines changed

CordovaLib/Classes/Public/CDVURLSchemeHandler.m renamed to CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVURLSchemeHandler.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one
1818
*/
1919

2020

21-
#import <Cordova/CDVURLSchemeHandler.h>
21+
#import "CDVURLSchemeHandler.h"
2222
#import <MobileCoreServices/MobileCoreServices.h>
2323

2424
#import <objc/message.h>

CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ Licensed to the Apache Software Foundation (ASF) under one
1919

2020
#import "CDVWebViewEngine.h"
2121
#import "CDVWebViewUIDelegate.h"
22+
#import "CDVURLSchemeHandler.h"
2223
#import <Cordova/CDVWebViewProcessPoolFactory.h>
2324
#import <Cordova/CDVSettingsDictionary.h>
24-
#import <Cordova/CDVURLSchemeHandler.h>
2525

2626
#import <objc/message.h>
2727

CordovaLib/CordovaLib.xcodeproj/project.pbxproj

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
/* Begin PBXBuildFile section */
2828
28BFF9141F355A4E00DDF01A /* CDVLogger.h in Headers */ = {isa = PBXBuildFile; fileRef = 28BFF9121F355A4E00DDF01A /* CDVLogger.h */; };
2929
28BFF9151F355A4E00DDF01A /* CDVLogger.m in Sources */ = {isa = PBXBuildFile; fileRef = 28BFF9131F355A4E00DDF01A /* CDVLogger.m */; };
30-
2F4D42BC23F218BA00501999 /* CDVURLSchemeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 2F4D42BA23F218BA00501999 /* CDVURLSchemeHandler.h */; settings = {ATTRIBUTES = (Public, ); }; };
31-
2F4D42BD23F218BA00501999 /* CDVURLSchemeHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 2F4D42BB23F218BA00501999 /* CDVURLSchemeHandler.m */; };
3230
2FCCEA17247E7366007276A8 /* CDVLaunchScreen.m in Sources */ = {isa = PBXBuildFile; fileRef = 4E714D3423F535B500A321AF /* CDVLaunchScreen.m */; };
3331
2FCCEA18247E7366007276A8 /* CDVLaunchScreen.h in Headers */ = {isa = PBXBuildFile; fileRef = 4E714D3223F535B500A321AF /* CDVLaunchScreen.h */; };
3432
3093E2231B16D6A3003F381A /* CDVIntentAndNavigationFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = 3093E2211B16D6A3003F381A /* CDVIntentAndNavigationFilter.h */; };
@@ -47,7 +45,6 @@
4745
4F56D833254A2ED90063F1D6 /* CDVWebViewProcessPoolFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = 4E23F8F523E16E96006CD852 /* CDVWebViewProcessPoolFactory.m */; };
4846
4F56D836254A2EE10063F1D6 /* CDVWebViewEngine.h in Headers */ = {isa = PBXBuildFile; fileRef = 4E23F8FA23E16E96006CD852 /* CDVWebViewEngine.h */; };
4947
4F56D839254A2EE40063F1D6 /* CDVWebViewProcessPoolFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 4E23F8F923E16E96006CD852 /* CDVWebViewProcessPoolFactory.h */; settings = {ATTRIBUTES = (Public, ); }; };
50-
4F56D83C254A2F2F0063F1D6 /* CDVURLSchemeHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 2F4D42BB23F218BA00501999 /* CDVURLSchemeHandler.m */; };
5148
7E7F69B91ABA3692007546F4 /* CDVHandleOpenURL.h in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95CF81AB9028C008C4574 /* CDVHandleOpenURL.h */; };
5249
7ED95D021AB9028C008C4574 /* CDVDebug.h in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95CF21AB9028C008C4574 /* CDVDebug.h */; };
5350
7ED95D031AB9028C008C4574 /* CDVJSON_private.h in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95CF31AB9028C008C4574 /* CDVJSON_private.h */; };
@@ -88,6 +85,10 @@
8885
9036843E2C6EB06500A3338C /* CDVAllowList.m in Sources */ = {isa = PBXBuildFile; fileRef = 9036843C2C6EB06500A3338C /* CDVAllowList.m */; };
8986
9036843F2C6EB06500A3338C /* CDVAllowList.m in Sources */ = {isa = PBXBuildFile; fileRef = 9036843C2C6EB06500A3338C /* CDVAllowList.m */; };
9087
903684402C6EB06500A3338C /* CDVAllowList.h in Headers */ = {isa = PBXBuildFile; fileRef = 9036843B2C6EB06500A3338C /* CDVAllowList.h */; };
88+
9047732F2C7A57E900373636 /* CDVURLSchemeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 9047732D2C7A57E900373636 /* CDVURLSchemeHandler.h */; };
89+
904773302C7A57E900373636 /* CDVURLSchemeHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 9047732E2C7A57E900373636 /* CDVURLSchemeHandler.m */; };
90+
904773312C7A57E900373636 /* CDVURLSchemeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 9047732D2C7A57E900373636 /* CDVURLSchemeHandler.h */; };
91+
904773322C7A57E900373636 /* CDVURLSchemeHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 9047732E2C7A57E900373636 /* CDVURLSchemeHandler.m */; };
9192
9052DE712150D040008E83D4 /* CDVAppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 7ED95D111AB9029B008C4574 /* CDVAppDelegate.m */; };
9293
9052DE722150D040008E83D4 /* CDVCommandDelegateImpl.m in Sources */ = {isa = PBXBuildFile; fileRef = 7ED95D161AB9029B008C4574 /* CDVCommandDelegateImpl.m */; };
9394
9052DE732150D040008E83D4 /* CDVCommandQueue.m in Sources */ = {isa = PBXBuildFile; fileRef = 7ED95D181AB9029B008C4574 /* CDVCommandQueue.m */; };
@@ -112,7 +113,6 @@
112113
9052DE8D2150D06B008E83D4 /* CDVGestureHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = A3B082D21BB15CEA00D8DC35 /* CDVGestureHandler.h */; };
113114
9052DE8E2150D06B008E83D4 /* CDVIntentAndNavigationFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = 3093E2211B16D6A3003F381A /* CDVIntentAndNavigationFilter.h */; };
114115
9052DE8F2150D06B008E83D4 /* CDVHandleOpenURL.h in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95CF81AB9028C008C4574 /* CDVHandleOpenURL.h */; };
115-
9059F51C26F2CE2400B3B2B7 /* CDVURLSchemeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 2F4D42BA23F218BA00501999 /* CDVURLSchemeHandler.h */; settings = {ATTRIBUTES = (Public, ); }; };
116116
9068B5332C6DFE2000B13532 /* CDVSettingsDictionary.h in Headers */ = {isa = PBXBuildFile; fileRef = 9068B5322C6DFE2000B13532 /* CDVSettingsDictionary.h */; settings = {ATTRIBUTES = (Public, ); }; };
117117
9068B5342C6DFE2000B13532 /* CDVSettingsDictionary.h in Headers */ = {isa = PBXBuildFile; fileRef = 9068B5322C6DFE2000B13532 /* CDVSettingsDictionary.h */; settings = {ATTRIBUTES = (Public, ); }; };
118118
9068B5362C6E007400B13532 /* CDVSettingsDictionary.m in Sources */ = {isa = PBXBuildFile; fileRef = 9068B5352C6E007400B13532 /* CDVSettingsDictionary.m */; };
@@ -145,8 +145,6 @@
145145
/* Begin PBXFileReference section */
146146
28BFF9121F355A4E00DDF01A /* CDVLogger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CDVLogger.h; sourceTree = "<group>"; };
147147
28BFF9131F355A4E00DDF01A /* CDVLogger.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CDVLogger.m; sourceTree = "<group>"; };
148-
2F4D42BA23F218BA00501999 /* CDVURLSchemeHandler.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CDVURLSchemeHandler.h; sourceTree = "<group>"; };
149-
2F4D42BB23F218BA00501999 /* CDVURLSchemeHandler.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CDVURLSchemeHandler.m; sourceTree = "<group>"; };
150148
3093E2211B16D6A3003F381A /* CDVIntentAndNavigationFilter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CDVIntentAndNavigationFilter.h; sourceTree = "<group>"; };
151149
3093E2221B16D6A3003F381A /* CDVIntentAndNavigationFilter.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CDVIntentAndNavigationFilter.m; sourceTree = "<group>"; };
152150
4E23F8F523E16E96006CD852 /* CDVWebViewProcessPoolFactory.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CDVWebViewProcessPoolFactory.m; sourceTree = "<group>"; };
@@ -197,6 +195,8 @@
197195
902D0BC12AEB64EB009C68E5 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
198196
9036843B2C6EB06500A3338C /* CDVAllowList.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CDVAllowList.h; sourceTree = "<group>"; };
199197
9036843C2C6EB06500A3338C /* CDVAllowList.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CDVAllowList.m; sourceTree = "<group>"; };
198+
9047732D2C7A57E900373636 /* CDVURLSchemeHandler.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CDVURLSchemeHandler.h; sourceTree = "<group>"; };
199+
9047732E2C7A57E900373636 /* CDVURLSchemeHandler.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CDVURLSchemeHandler.m; sourceTree = "<group>"; };
200200
9068B5322C6DFE2000B13532 /* CDVSettingsDictionary.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CDVSettingsDictionary.h; sourceTree = "<group>"; };
201201
9068B5352C6E007400B13532 /* CDVSettingsDictionary.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CDVSettingsDictionary.m; sourceTree = "<group>"; };
202202
A3B082D21BB15CEA00D8DC35 /* CDVGestureHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CDVGestureHandler.h; sourceTree = "<group>"; };
@@ -268,6 +268,8 @@
268268
4E23F8F423E16D30006CD852 /* CDVWebViewEngine */ = {
269269
isa = PBXGroup;
270270
children = (
271+
9047732D2C7A57E900373636 /* CDVURLSchemeHandler.h */,
272+
9047732E2C7A57E900373636 /* CDVURLSchemeHandler.m */,
271273
4E23F8FA23E16E96006CD852 /* CDVWebViewEngine.h */,
272274
4E23F8F823E16E96006CD852 /* CDVWebViewEngine.m */,
273275
4E23F8F623E16E96006CD852 /* CDVWebViewUIDelegate.h */,
@@ -338,7 +340,6 @@
338340
7ED95D2B1AB9029B008C4574 /* CDVViewController.m */,
339341
7ED95D321AB9029B008C4574 /* NSDictionary+CordovaPreferences.m */,
340342
7ED95D341AB9029B008C4574 /* NSMutableArray+QueueAdditions.m */,
341-
2F4D42BB23F218BA00501999 /* CDVURLSchemeHandler.m */,
342343
);
343344
name = Public;
344345
path = Classes/Public;
@@ -373,7 +374,6 @@
373374
7ED95D2A1AB9029B008C4574 /* CDVViewController.h */,
374375
4E23F8F923E16E96006CD852 /* CDVWebViewProcessPoolFactory.h */,
375376
7ED95D2C1AB9029B008C4574 /* CDVWebViewEngineProtocol.h */,
376-
2F4D42BA23F218BA00501999 /* CDVURLSchemeHandler.h */,
377377
7ED95D311AB9029B008C4574 /* NSDictionary+CordovaPreferences.h */,
378378
7ED95D331AB9029B008C4574 /* NSMutableArray+QueueAdditions.h */,
379379
);
@@ -411,7 +411,6 @@
411411
C0C01EC41E39131A0056E6CB /* CDVPlugin+Resources.h in Headers */,
412412
C0C01EC51E39131A0056E6CB /* CDVPlugin.h in Headers */,
413413
C0C01EC61E39131A0056E6CB /* CDVPluginResult.h in Headers */,
414-
9059F51C26F2CE2400B3B2B7 /* CDVURLSchemeHandler.h in Headers */,
415414
C0C01EC71E39131A0056E6CB /* CDVScreenOrientationDelegate.h in Headers */,
416415
4F56D836254A2EE10063F1D6 /* CDVWebViewEngine.h in Headers */,
417416
C0C01EC81E39131A0056E6CB /* CDVTimer.h in Headers */,
@@ -428,6 +427,7 @@
428427
903684402C6EB06500A3338C /* CDVAllowList.h in Headers */,
429428
9052DE8E2150D06B008E83D4 /* CDVIntentAndNavigationFilter.h in Headers */,
430429
9052DE8F2150D06B008E83D4 /* CDVHandleOpenURL.h in Headers */,
430+
9047732F2C7A57E900373636 /* CDVURLSchemeHandler.h in Headers */,
431431
2FCCEA18247E7366007276A8 /* CDVLaunchScreen.h in Headers */,
432432
);
433433
runOnlyForDeploymentPostprocessing = 0;
@@ -446,7 +446,6 @@
446446
7ED95D3D1AB9029B008C4574 /* CDVCommandQueue.h in Headers */,
447447
4E23F8FF23E16E96006CD852 /* CDVWebViewProcessPoolFactory.h in Headers */,
448448
7ED95D3F1AB9029B008C4574 /* CDVConfigParser.h in Headers */,
449-
2F4D42BC23F218BA00501999 /* CDVURLSchemeHandler.h in Headers */,
450449
7ED95D411AB9029B008C4574 /* CDVInvokedUrlCommand.h in Headers */,
451450
7ED95D431AB9029B008C4574 /* CDVPlugin+Resources.h in Headers */,
452451
7ED95D451AB9029B008C4574 /* CDVPlugin.h in Headers */,
@@ -468,6 +467,7 @@
468467
9036843D2C6EB06500A3338C /* CDVAllowList.h in Headers */,
469468
3093E2231B16D6A3003F381A /* CDVIntentAndNavigationFilter.h in Headers */,
470469
7E7F69B91ABA3692007546F4 /* CDVHandleOpenURL.h in Headers */,
470+
904773312C7A57E900373636 /* CDVURLSchemeHandler.h in Headers */,
471471
4E714D3623F535B500A321AF /* CDVLaunchScreen.h in Headers */,
472472
);
473473
runOnlyForDeploymentPostprocessing = 0;
@@ -579,11 +579,11 @@
579579
4F56D833254A2ED90063F1D6 /* CDVWebViewProcessPoolFactory.m in Sources */,
580580
4F56D82D254A2EB50063F1D6 /* CDVWebViewEngine.m in Sources */,
581581
9052DE7C2150D040008E83D4 /* CDVViewController.m in Sources */,
582-
4F56D83C254A2F2F0063F1D6 /* CDVURLSchemeHandler.m in Sources */,
583582
9052DE7E2150D040008E83D4 /* NSDictionary+CordovaPreferences.m in Sources */,
584583
9052DE7F2150D040008E83D4 /* NSMutableArray+QueueAdditions.m in Sources */,
585584
9052DE802150D040008E83D4 /* CDVJSON_private.m in Sources */,
586585
9052DE812150D040008E83D4 /* CDVLogger.m in Sources */,
586+
904773302C7A57E900373636 /* CDVURLSchemeHandler.m in Sources */,
587587
9052DE822150D040008E83D4 /* CDVGestureHandler.m in Sources */,
588588
9052DE832150D040008E83D4 /* CDVIntentAndNavigationFilter.m in Sources */,
589589
9052DE842150D040008E83D4 /* CDVHandleOpenURL.m in Sources */,
@@ -602,7 +602,6 @@
602602
7ED95D421AB9029B008C4574 /* CDVInvokedUrlCommand.m in Sources */,
603603
7ED95D441AB9029B008C4574 /* CDVPlugin+Resources.m in Sources */,
604604
9068B5372C6E007400B13532 /* CDVSettingsDictionary.m in Sources */,
605-
2F4D42BD23F218BA00501999 /* CDVURLSchemeHandler.m in Sources */,
606605
7ED95D461AB9029B008C4574 /* CDVPlugin.m in Sources */,
607606
9036843E2C6EB06500A3338C /* CDVAllowList.m in Sources */,
608607
7ED95D481AB9029B008C4574 /* CDVPluginResult.m in Sources */,
@@ -615,6 +614,7 @@
615614
7ED95D041AB9028C008C4574 /* CDVJSON_private.m in Sources */,
616615
4E23F8FD23E16E96006CD852 /* CDVWebViewUIDelegate.m in Sources */,
617616
28BFF9151F355A4E00DDF01A /* CDVLogger.m in Sources */,
617+
904773322C7A57E900373636 /* CDVURLSchemeHandler.m in Sources */,
618618
A3B082D51BB15CEA00D8DC35 /* CDVGestureHandler.m in Sources */,
619619
3093E2241B16D6A3003F381A /* CDVIntentAndNavigationFilter.m in Sources */,
620620
7ED95D071AB9028C008C4574 /* CDVHandleOpenURL.m in Sources */,

CordovaLib/include/Cordova/Cordova.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
#import <Cordova/NSMutableArray+QueueAdditions.h>
3737
#import <Cordova/CDVScreenOrientationDelegate.h>
3838
#import <Cordova/CDVTimer.h>
39-
#import <Cordova/CDVURLSchemeHandler.h>
4039

4140
// Deprecated
4241
#import <Cordova/CDV.h>

0 commit comments

Comments
 (0)