You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Define a MSRV policy (maybe copy the existing DataFusion one)
Implement some sort of CI check (again can copy / reuse the datafusion one if we want)
🤔 interestingly we don't seem to have an MSRV policy in this crate (at least not that I could find in https://github.com/apache/datafusion-sqlparser-rs/blob/main/README.md)
From looking into #1612, some test code uses associated type bounds (stabilized in 1.79). It could be rewritten if an earlier MSRV is desired (1.75 worked without it). That's moot if following a more progressive policy like DataFusion though.
From looking into #1612, some test code uses associated type bounds (stabilized in 1.79). It could be rewritten if an earlier MSRV is desired (1.75 worked without it). That's moot if following a more progressive policy like DataFusion though.
I don't have a strong preference -- I think keeping sqlparser simple / easy to embed sounds like a good idea but all the projects I care about use newer versions of rust 🤷
Hopefully others can chime in with their points of view
TLDR woudl be:
We do have such a thing in DataFusion here: https://github.com/apache/datafusion?tab=readme-ov-file#rust-version-compatibility-policy
Maybe it is worth considering adding some documentation / policy in the sqlparser crate too 🤔
Originally posted by @alamb in #1736 (comment)
The text was updated successfully, but these errors were encountered: