refactor of RuntimeFilter

update

update

update

update

update

update

fix

Author: BiteTheDDDDt

be/src/exprs/bitmapfilter_predicate.h

@@ -19,7 +19,7 @@
 
 #include <algorithm>
 
-#include "exprs/runtime_filter.h"
+#include "exprs/runtime_filter/runtime_filter_definitions.h"
 #include "gutil/integral_types.h"
 #include "runtime/define_primitive_type.h"
 #include "runtime/primitive_type.h"

be/src/exprs/bloom_filter_func.h

@@ -20,9 +20,10 @@
 #include "common/exception.h"
 #include "common/status.h"
 #include "exprs/block_bloom_filter.hpp"
-#include "exprs/runtime_filter.h"
+#include "exprs/runtime_filter/runtime_filter_definitions.h"
 #include "olap/rowset/segment_v2/bloom_filter.h" // IWYU pragma: keep
 #include "vec/columns/column_dictionary.h"
+#include "vec/columns/column_nullable.h"
 #include "vec/common/string_ref.h"
 
 namespace doris {
@@ -129,6 +130,7 @@ class BloomFilterFuncBase : public RuntimeFilterFuncBase {
         _runtime_bloom_filter_max_size = params->runtime_bloom_filter_max_size;
         _null_aware = params->null_aware;
         _bloom_filter_size_calculated_by_ndv = params->bloom_filter_size_calculated_by_ndv;
+        _enable_fixed_len_to_uint32_v2 = params->enable_fixed_len_to_uint32_v2;
         _limit_length();
     }
 
@@ -234,16 +236,14 @@ class BloomFilterFuncBase : public RuntimeFilterFuncBase {
 
     void set_contain_null_and_null_aware() { _bloom_filter->set_contain_null_and_null_aware(); }
 
-    void set_enable_fixed_len_to_uint32_v2() { _enable_fixed_len_to_uint32_v2 = true; }
-
     size_t get_size() const { return _bloom_filter ? _bloom_filter->size() : 0; }
 
     void light_copy(BloomFilterFuncBase* bloomfilter_func) {
         auto* other_func = static_cast<BloomFilterFuncBase*>(bloomfilter_func);
         _bloom_filter_alloced = other_func->_bloom_filter_alloced;
         _bloom_filter = other_func->_bloom_filter;
         _inited = other_func->_inited;
-        _enable_fixed_len_to_uint32_v2 |= other_func->_enable_fixed_len_to_uint32_v2;
+        _enable_fixed_len_to_uint32_v2 = other_func->_enable_fixed_len_to_uint32_v2;
         set_filter_id(bloomfilter_func->get_filter_id());
     }
 

be/src/exprs/create_predicate_function.h

@@ -130,8 +130,7 @@ typename Traits::BasePtr create_predicate_function(PrimitiveType type) {
         APPLY_FOR_PRIMTYPE(M)
 #undef M
     default:
-        throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
-                               "predicate with type " + type_to_string(type));
+        throw Status::InternalError("predicate with type " + type_to_string(type));
     }
 
     return nullptr;
@@ -151,7 +150,7 @@ typename Traits::BasePtr create_bitmap_predicate_function(PrimitiveType type) {
     case TYPE_BIGINT:
         return Creator::template create<TYPE_BIGINT>();
     default:
-        DCHECK(false) << "Invalid type: " << type_to_string(type);
+        throw Status::InternalError("bitmap predicate with type " + type_to_string(type));
     }
 
     return nullptr;

be/src/exprs/hybrid_set.h

@@ -17,8 +17,13 @@
 
 #pragma once
 
-#include "exprs/runtime_filter.h"
-#include "exprs/runtime_filter_convertor.h"
+#include "common/object_pool.h"
+#include "exprs/runtime_filter/utils.h"
+#include "runtime/primitive_type.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/columns/column_string.h"
+#include "vec/columns/column_vector.h"
+#include "vec/common/hash_table/phmap_fwd_decl.h"
 
 namespace doris {
 

be/src/exprs/minmax_predicate.h

@@ -17,10 +17,13 @@
 
 #pragma once
 
-#include "exprs/runtime_filter.h"
-#include "exprs/runtime_filter_convertor.h"
+#include "exprs/runtime_filter/utils.h"
+#include "runtime/type_limit.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/columns/column_string.h"
 
 namespace doris {
+
 // only used in Runtime Filter
 class MinMaxFuncBase : public RuntimeFilterFuncBase {
 public: