Skip to content

Commit 2f86484

Browse files
committed
[FLINK-36278] Decrease log levels for hotpath logs
We should never use INFO for tracking records on the hotpath. Ideally, we would use trace but for this commit I just decreased to DEBUG to minimize the impact on production settings (is it even possible to leave production on INFO currently?).
1 parent c0be7d5 commit 2f86484

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/reader/DynamicKafkaSourceReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public InputStatus pollNext(ReaderOutput<T> readerOutput) throws Exception {
138138
}
139139

140140
if (restartingReaders.get()) {
141-
logger.info("Poll next invoked while restarting readers");
141+
logger.debug("Poll next invoked while restarting readers");
142142
return logAndReturnInputStatus(InputStatus.NOTHING_AVAILABLE);
143143
}
144144

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/DynamicKafkaSourceExternalContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ public void writeRecords(List<String> records) {
240240
}
241241
}
242242

243-
logger.info("Writing producer records: {}", producerRecords);
243+
logger.debug("Writing producer records: {}", producerRecords);
244244

245245
DynamicKafkaSourceTestHelper.produceToKafka(
246246
clusterPropertiesMap.get(cluster),

flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2097,7 +2097,7 @@ public void flatMap(
20972097

20982098
count++;
20992099

2100-
LOG.info("Received message {}, total {} messages", value, count);
2100+
LOG.debug("Received message {}, total {} messages", value, count);
21012101

21022102
// verify if we've seen everything
21032103
if (count == finalCount) {

flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public static void startClusters(KafkaTestEnvironment.Config environmentConfig)
167167
throws Exception {
168168
kafkaServer = constructKafkaTestEnvironment();
169169

170-
LOG.info("Starting KafkaTestBase.prepare() for Kafka " + kafkaServer.getVersion());
170+
LOG.info("Starting KafkaTestBase.prepare() for Kafka {}", kafkaServer.getVersion());
171171

172172
kafkaServer.prepare(environmentConfig);
173173

0 commit comments

Comments
 (0)