[FLINK-36278] Reduce log size by avoiding container logs by default

Currently, container logs appear under an o.a.f logger and thus are visible on CI. This results in compressed log size >40MB for a run and often leads to download errors.

This PR reroutes container logs to a special container logger. It also uses a custom format to significantly reduce the size of each log line. The logs for containers are disabled by default.

Author: AHeise

flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SmokeKafkaITCase.java

@@ -78,7 +78,7 @@ class SmokeKafkaITCase {
 
     @Container
     public static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG)
+            createKafkaContainer(KAFKA)
                     .withEmbeddedZookeeper()
                     .withNetwork(NETWORK)
                     .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS);

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducerITCase.java

@@ -61,7 +61,7 @@ class FlinkKafkaInternalProducerITCase {
 
     @Container
     private static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG).withEmbeddedZookeeper();
+            createKafkaContainer(KAFKA).withEmbeddedZookeeper();
 
     @Test
     void testInitTransactionId() {

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java

@@ -124,7 +124,7 @@ public class KafkaSinkITCase extends TestLogger {
 
     @ClassRule
     public static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG)
+            createKafkaContainer(KAFKA)
                     .withEmbeddedZookeeper()
                     .withNetwork(NETWORK)
                     .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS);

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java

@@ -57,7 +57,7 @@ public class KafkaTransactionLogITCase extends TestLogger {
 
     @ClassRule
     public static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG).withEmbeddedZookeeper();
+            createKafkaContainer(KAFKA).withEmbeddedZookeeper();
 
     private final List<Producer<byte[], Integer>> openProducers = new ArrayList<>();
 

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterTestBase.java

@@ -73,7 +73,7 @@ public abstract class KafkaWriterTestBase {
     protected TriggerTimeService timeService;
 
     protected static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG)
+            createKafkaContainer(KAFKA)
                     .withEmbeddedZookeeper()
                     .withNetwork(NETWORK)
                     .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS);

flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaUtil.java

@@ -18,8 +18,6 @@
 
 package org.apache.flink.connector.kafka.testutils;
 
-import org.apache.flink.util.StringUtils;
-
 import org.apache.kafka.clients.consumer.ConsumerConfig;
 import org.apache.kafka.clients.consumer.ConsumerRecord;
 import org.apache.kafka.clients.consumer.ConsumerRecords;
@@ -54,19 +52,21 @@ private KafkaUtil() {}
      * levels with the ones used by the capturing logger.
      *
      * @param dockerImageVersion describing the Kafka image
-     * @param logger to derive the log level from
      * @return configured Kafka container
      */
-    public static KafkaContainer createKafkaContainer(String dockerImageVersion, Logger logger) {
-        return createKafkaContainer(dockerImageVersion, logger, null);
+    public static KafkaContainer createKafkaContainer(String dockerImageVersion) {
+        return createKafkaContainer(dockerImageVersion, "Kafka");
     }
 
     /**
      * This method helps to set commonly used Kafka configurations and aligns the internal Kafka log
      * levels with the ones used by the capturing logger, and set the prefix of logger.
      */
     public static KafkaContainer createKafkaContainer(
-            String dockerImageVersion, Logger logger, String loggerPrefix) {
+            String dockerImageVersion, String containerName) {
+
+        Logger logger = LoggerFactory.getLogger("container." + containerName);
+
         String logLevel;
         if (logger.isTraceEnabled()) {
             logLevel = "TRACE";
@@ -82,10 +82,7 @@ public static KafkaContainer createKafkaContainer(
             logLevel = "OFF";
         }
 
-        Slf4jLogConsumer logConsumer = new Slf4jLogConsumer(logger);
-        if (!StringUtils.isNullOrWhitespaceOnly(loggerPrefix)) {
-            logConsumer.withPrefix(loggerPrefix);
-        }
+        Slf4jLogConsumer logConsumer = new Slf4jLogConsumer(logger, true);
         return new KafkaContainer(DockerImageName.parse(dockerImageVersion))
                 .withEnv("KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR", "1")
                 .withEnv("KAFKA_TRANSACTION_STATE_LOG_MIN_ISR", "1")

flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationTest.java

@@ -54,7 +54,6 @@ protected Properties createProperties() {
         Properties properties = new Properties();
         properties.putAll(standardProps);
         properties.putAll(secureProps);
-        properties.put(ProducerConfig.CLIENT_ID_CONFIG, "producer-client-id");
         properties.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, "producer-transaction-id");
         properties.put(FlinkKafkaProducer.KEY_DISABLE_METRICS, "true");
         return properties;

flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java

@@ -434,7 +434,7 @@ private KafkaContainer createKafkaContainer(
             int brokerID, @Nullable GenericContainer<?> zookeeper) {
         String brokerName = String.format("Kafka-%d", brokerID);
         KafkaContainer broker =
-                KafkaUtil.createKafkaContainer(DockerImageVersions.KAFKA, LOG, brokerName)
+                KafkaUtil.createKafkaContainer(DockerImageVersions.KAFKA, brokerName)
                         .withNetworkAliases(brokerName)
                         .withEnv("KAFKA_BROKER_ID", String.valueOf(brokerID))
                         .withEnv("KAFKA_MESSAGE_MAX_BYTES", String.valueOf(50 * 1024 * 1024))

flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricMutableWrapperTest.java

@@ -55,7 +55,7 @@ class KafkaMetricMutableWrapperTest {
 
     @Container
     public static final KafkaContainer KAFKA_CONTAINER =
-            createKafkaContainer(KAFKA, LOG)
+            createKafkaContainer(KAFKA)
                     .withEmbeddedZookeeper()
                     .withNetwork(NETWORK)
                     .withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS);

flink-connector-kafka/src/test/resources/log4j2-test.properties

@@ -37,5 +37,15 @@ logger.zookeeper.level = OFF
 logger.I0Itec.name = org.I0Itec
 logger.I0Itec.level = OFF
 
-logger.splitreader.name = org.apache.flink.connector.kafka.source.reader.KafkaPartitionSplitReader
-logger.splitreader.level = DEBUG
+# Logger configuration for containers, by default this is off
+# If you want to investigate test failures, overwrite the level as above
+logger.containerlogger.name = container
+logger.containerlogger.level = OFF
+logger.containerlogger.additivity = false  # This prevents messages from being logged by the root logger
+logger.containerlogger.appenderRef.containerappender.ref = ContainerLogger
+
+appender.containerappender.name = ContainerLogger
+appender.containerappender.type = CONSOLE
+appender.containerappender.target = SYSTEM_ERR
+appender.containerappender.layout.type = PatternLayout
+appender.containerappender.layout.pattern = [%c{1}] %m%n