Fixed NPE in debug log

ok2c · ok2c · commit 9e3d79bedeee · 2023-12-10T12:40:50.000+01:00
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
@@ -409,7 +409,11 @@ public void release(final ConnectionEndpoint endpoint, final Object state, final
                 }
             } else {
                 if (LOG.isDebugEnabled()) {
-                    LOG.debug("{} connection is not kept alive(isConsistent:{})", ConnPoolSupport.getId(endpoint), conn.isConsistent());
+                    if (conn != null && !conn.isConsistent()) {
+                        LOG.debug("{} connection is in an inconsistent state and cannot be kept alive)", ConnPoolSupport.getId(endpoint));
+                    } else {
+                        LOG.debug("{} connection is not kept alive)", ConnPoolSupport.getId(endpoint));
+                    }
                 }
             }
         } catch (final RuntimeException ex) {

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,11 @@ public void release(final ConnectionEndpoint endpoint, final Object state, final`
`409`	`409`	`}`
`410`	`410`	`} else {`
`411`	`411`	`if (LOG.isDebugEnabled()) {`
`412`		`- LOG.debug("{} connection is not kept alive(isConsistent:{})", ConnPoolSupport.getId(endpoint), conn.isConsistent());`
	`412`	`+ if (conn != null && !conn.isConsistent()) {`
	`413`	`+ LOG.debug("{} connection is in an inconsistent state and cannot be kept alive)", ConnPoolSupport.getId(endpoint));`
	`414`	`+ } else {`
	`415`	`+ LOG.debug("{} connection is not kept alive)", ConnPoolSupport.getId(endpoint));`
	`416`	`+ }`
`413`	`417`	`}`
`414`	`418`	`}`
`415`	`419`	`} catch (final RuntimeException ex) {`