From 6e2ef32d75757af1f1c5ae88d9e13c84e46b752e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20P=C3=BCtz?= <tobias@hansetag.com>
Date: Tue, 4 Feb 2025 19:44:55 +0100
Subject: [PATCH] fix(s3): path-style-access means no virtual-host (#944)

Hi, I noticed that this boolean check was inverted, it applied virtual
host style access if path style access was true and vice-versa.
---
 crates/iceberg/src/io/storage_s3.rs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/crates/iceberg/src/io/storage_s3.rs b/crates/iceberg/src/io/storage_s3.rs
index ec66f4750..30f61fe39 100644
--- a/crates/iceberg/src/io/storage_s3.rs
+++ b/crates/iceberg/src/io/storage_s3.rs
@@ -89,9 +89,7 @@ pub(crate) fn s3_config_parse(mut m: HashMap<String, String>) -> Result<S3Config
         cfg.region = Some(region);
     };
     if let Some(path_style_access) = m.remove(S3_PATH_STYLE_ACCESS) {
-        if is_truthy(path_style_access.to_lowercase().as_str()) {
-            cfg.enable_virtual_host_style = true;
-        }
+        cfg.enable_virtual_host_style = !is_truthy(path_style_access.to_lowercase().as_str());
     };
     if let Some(arn) = m.remove(S3_ASSUME_ROLE_ARN) {
         cfg.role_arn = Some(arn);