optimize: fix go vet issue (#892)

fix go vet

Co-authored-by: FengZhang <[email protected]>

Author: slievrly

pkg/datasource/sql/datasource/base/meta_cache_test.go

@@ -73,7 +73,6 @@ func (m *mockTrigger) LoadAll(ctx context.Context, dbName string, conn *sql.Conn
 
 func TestBaseTableMetaCache_refresh(t *testing.T) {
 	type fields struct {
-		lock           sync.RWMutex
 		expireDuration time.Duration
 		capity         int32
 		size           int32
@@ -96,7 +95,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
 		{
 			name: "test1",
 			fields: fields{
-				lock:           sync.RWMutex{},
 				capity:         capacity,
 				size:           0,
 				expireDuration: EexpireTime,
@@ -117,7 +115,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
 		{
 			name: "test2",
 			fields: fields{
-				lock:           sync.RWMutex{},
 				capity:         capacity,
 				size:           0,
 				expireDuration: EexpireTime,
@@ -154,7 +151,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
 			defer loadAllStub.Reset()
 
 			c := &BaseTableMetaCache{
-				lock:           tt.fields.lock,
 				expireDuration: tt.fields.expireDuration,
 				capity:         tt.fields.capity,
 				size:           tt.fields.size,

pkg/datasource/sql/exec/at/base_executor_test.go

@@ -67,8 +67,8 @@ func TestBaseExecBuildLockKey(t *testing.T) {
 			types.RecordImage{
 				TableName: "test_name",
 				Rows: []types.RowImage{
-					{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "user1")}},
-					{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "user2")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "user1")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "user2")}},
 				},
 			},
 			"TEST_NAME:1_user1,2_user2",
@@ -84,9 +84,9 @@ func TestBaseExecBuildLockKey(t *testing.T) {
 			types.RecordImage{
 				TableName: "test2_name",
 				Rows: []types.RowImage{
-					{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
-					{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
-					{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
 				},
 			},
 			"TEST2_NAME:1_one_11,2_two_22,3_three_33",

pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go

@@ -93,8 +93,8 @@ func TestBuildLockKey(t *testing.T) {
 			types.RecordImage{
 				TableName: "test_name",
 				Rows: []types.RowImage{
-					{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
-					{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
 				},
 			},
 			"TEST_NAME:1_one,2_two",
@@ -110,9 +110,9 @@ func TestBuildLockKey(t *testing.T) {
 			types.RecordImage{
 				TableName: "test2_name",
 				Rows: []types.RowImage{
-					{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
-					{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
-					{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"), getColumnImage("age", "11")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"), getColumnImage("age", "22")}},
+					{Columns: []types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"), getColumnImage("age", "33")}},
 				},
 			},
 			"TEST2_NAME:1_one_11,2_two_22,3_three_33",