Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP protocol implementation: allow to configure which protocol version(s) to use #827

Closed
sebastian-nagel opened this issue Oct 5, 2020 · 1 comment
Closed

HTTP protocol implementation: allow to configure which protocol version(s) to use #827

sebastian-nagel opened this issue Oct 5, 2020 · 1 comment
Labels
core enhancement warc
Milestone
1.18

Comments

@sebastian-nagel
Copy link
Contributor

It should be possible to configure which HTTP protocol versions (HTTP/1.1, HTTP/2, etc.) are used by a protocol implementation:
@sebastian-nagel sebastian-nagel added this to the 1.18 milestone Oct 5, 2020
@sebastian-nagel sebastian-nagel mentioned this issue Oct 5, 2020
Closed
sebastian-nagel added a commit to sebastian-nagel/storm-crawler that referenced this issue Oct 5, 2020
@sebastian-nagel
HTTP protocol implementation: allow to configure which protocol versi…
8e893a8 
…on(s) to use

implements apache#827
- configuration key `http.protocol.versions` holds a list of protocols
  in order of preference
- implement selection of protocols in okhttp protocol implementation
- fix loading of YAML lists when configuration isn't loaded via Storm
  (eg. by main method of AbstractHttpProtocol)
sebastian-nagel added a commit to sebastian-nagel/storm-crawler that referenced this issue Oct 5, 2020
@sebastian-nagel
HTTP protocol implementation: allow to configure which protocol versi…
c001b62 
…on(s) to use

implements apache#827
- configuration key `http.protocol.versions` holds a list of protocols
  in order of preference
- implement selection of protocols in okhttp protocol implementation
- fix loading of YAML lists when configuration isn't loaded via Storm
  (eg. by main method of AbstractHttpProtocol)
@sebastian-nagel sebastian-nagel mentioned this issue Oct 5, 2020
Merged
jnioche pushed a commit that referenced this issue Oct 6, 2020
@sebastian-nagel
HTTP protocol implementation: allow to configure which protocol versi…
6a5951d 
…on(s) to use (#829)

implements #827
- configuration key `http.protocol.versions` holds a list of protocols
  in order of preference
- implement selection of protocols in okhttp protocol implementation
- fix loading of YAML lists when configuration isn't loaded via Storm
  (eg. by main method of AbstractHttpProtocol)
@jnioche
Copy link
Contributor

jnioche commented Oct 6, 2020

fixed in #829

@jnioche jnioche closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement warc
Projects
None yet
Milestone
1.18
Development

No branches or pull requests
2 participants
@jnioche @sebastian-nagel