Skip to content

Commit

Permalink
KAFKA-17162: join() started thread in DefaultTaskManagerTest (#18570)
Browse files Browse the repository at this point in the history
Reviewers: Lucas Brutschy <[email protected]>
  • Loading branch information
mjsax authored Jan 28, 2025
1 parent e89b30d commit dc396f4
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ public void shouldBlockOnAwait() throws InterruptedException {
assertFalse(awaitingRunnable.awaitDone.await(100, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand All @@ -151,6 +152,7 @@ public void shouldReturnFromAwaitOnInterruption() throws InterruptedException {
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand All @@ -165,6 +167,7 @@ public void shouldReturnFromAwaitOnSignalProcessableTasks() throws InterruptedEx
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand All @@ -184,6 +187,7 @@ public void shouldReturnFromAwaitOnUnassignment() throws InterruptedException {
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand All @@ -198,6 +202,7 @@ public void shouldReturnFromAwaitOnAdding() throws InterruptedException {
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand All @@ -214,6 +219,7 @@ public void shouldReturnFromAwaitOnUnlocking() throws InterruptedException {
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));

awaitingRunnable.shutdown();
awaitingThread.join();
}

@Test
Expand Down

0 comments on commit dc396f4

Please sign in to comment.