Skip to content

Commit dc396f4

Browse files
authored
KAFKA-17162: join() started thread in DefaultTaskManagerTest (#18570)
Reviewers: Lucas Brutschy <[email protected]>
1 parent e89b30d commit dc396f4

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ public void shouldBlockOnAwait() throws InterruptedException {
137137
assertFalse(awaitingRunnable.awaitDone.await(100, TimeUnit.MILLISECONDS));
138138

139139
awaitingRunnable.shutdown();
140+
awaitingThread.join();
140141
}
141142

142143
@Test
@@ -151,6 +152,7 @@ public void shouldReturnFromAwaitOnInterruption() throws InterruptedException {
151152
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));
152153

153154
awaitingRunnable.shutdown();
155+
awaitingThread.join();
154156
}
155157

156158
@Test
@@ -165,6 +167,7 @@ public void shouldReturnFromAwaitOnSignalProcessableTasks() throws InterruptedEx
165167
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));
166168

167169
awaitingRunnable.shutdown();
170+
awaitingThread.join();
168171
}
169172

170173
@Test
@@ -184,6 +187,7 @@ public void shouldReturnFromAwaitOnUnassignment() throws InterruptedException {
184187
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));
185188

186189
awaitingRunnable.shutdown();
190+
awaitingThread.join();
187191
}
188192

189193
@Test
@@ -198,6 +202,7 @@ public void shouldReturnFromAwaitOnAdding() throws InterruptedException {
198202
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));
199203

200204
awaitingRunnable.shutdown();
205+
awaitingThread.join();
201206
}
202207

203208
@Test
@@ -214,6 +219,7 @@ public void shouldReturnFromAwaitOnUnlocking() throws InterruptedException {
214219
assertTrue(awaitingRunnable.awaitDone.await(VERIFICATION_TIMEOUT, TimeUnit.MILLISECONDS));
215220

216221
awaitingRunnable.shutdown();
222+
awaitingThread.join();
217223
}
218224

219225
@Test

0 commit comments

Comments
 (0)