Skip to content

Commit 5032334

Browse files
committed
Add test for initialFileTime returning rounded millis
1 parent d1cc807 commit 5032334

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManagerTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,17 @@ void testRolloverOfDeletedFile() throws IOException {
227227

228228
@Test
229229
@Issue("https://github.com/apache/logging-log4j2/issues/3068")
230-
void testInitialTimeRounded() {
230+
void testInitialTimeRounded() throws IOException {
231231
assertEquals(1755031147000L, RollingFileManager.roundMillis(1755031147000L));
232232
assertEquals(1755031147000L, RollingFileManager.roundMillis(1755031147123L));
233233
assertEquals(1755031147000L, RollingFileManager.roundMillis(1755031147499L));
234234
assertEquals(1755031148000L, RollingFileManager.roundMillis(1755031147500L));
235235
assertEquals(1755031148000L, RollingFileManager.roundMillis(1755031147999L));
236236
assertEquals(1755031148000L, RollingFileManager.roundMillis(1755031148000L));
237+
238+
final File file = File.createTempFile("testFile", "log");
239+
file.deleteOnExit();
240+
241+
assertEquals(0, RollingFileManager.initialFileTime(file) % 1000);
237242
}
238243
}

log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ public RollingFileManager createManager(final String name, final FactoryData dat
910910
}
911911
}
912912

913-
private static long initialFileTime(final File file) {
913+
static long initialFileTime(final File file) {
914914
final Path path = file.toPath();
915915
if (Files.exists(path)) {
916916
try {

0 commit comments

Comments
 (0)