Skip to content

Commit

Permalink
Deprecate ueJql
Browse files Browse the repository at this point in the history
  • Loading branch information
elharo committed Nov 22, 2024
1 parent b36a2b4 commit b0abb8a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,10 @@ public class AnnouncementMojo extends AbstractAnnouncementMojo {
private String templateEncoding;

/**
* Use the JIRA query language instead of the JIRA query based on HTTP parameters. From JIRA 5.1 and up only JQL is
* supported. JIRA 4.4 supports both JQL and URL parameter based queries. From 5.1.1 this is obsolete, since REST
* queries only use JQL.
* Obsolete, since REST queries always use JQL.
*
* @since 2.10
* @deprecated ignored; remove from your configs
*/
@Parameter(property = "changes.useJql", defaultValue = "false")
private boolean useJql;
Expand Down Expand Up @@ -725,8 +724,6 @@ protected List<Release> getJiraReleases() throws MojoExecutionException {
jiraDownloader.setJiraPassword(jiraPassword);
}

jiraDownloader.setUseJql(useJql);

jiraDownloader.setWebUser(webUser);

jiraDownloader.setWebPassword(webPassword);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
import org.apache.maven.settings.Settings;

/**
* Abstract API, more or less, to retrieving issue information from JIRA. Intended to have subclasses for the old (RSS)
* and new (REST) ways of doing things.
* Abstract API, more or less, to retrieve issue information from JIRA. Has a subclass for
* new (REST) ways of doing things.
*
* @author [email protected]
* @author [email protected]
Expand Down Expand Up @@ -91,12 +91,6 @@ public abstract class AbstractJiraDownloader {
/** The maven settings. */
protected Settings settings;

/**
* Use JQL, JIRA query language, instead of URL parameter based queries. Note that this is down here to make it
* easier for the mojo to deal with both new and old flavors.
*/
protected boolean useJql;

/** Filter the JIRA query based on the current version */
protected boolean onlyCurrentVersion;

Expand Down Expand Up @@ -337,14 +331,6 @@ public void setSettings(Settings settings) {
this.settings = settings;
}

public boolean isUseJql() {
return useJql;
}

public void setUseJql(boolean useJql) {
this.useJql = useJql;
}

public boolean isOnlyCurrentVersion() {
return onlyCurrentVersion;
}
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/apache/maven/plugins/jira/JiraReport.java
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ public class JiraReport extends AbstractChangesReport {
private String columnNames;

/**
* Use the JIRA query language instead of the JIRA query based on HTTP parameters. From JIRA 5.1 and up only JQL is
* supported. JIRA 4.4 supports both JQL and URL parameter based queries. From 5.1.1 this is obsolete, since REST
* queries only use JQL.
* Obsolete, since REST queries only use JQL.
*
* @since 2.8
* @deprecated ignored; delete from your config
*/
@Deprecated
@Parameter(property = "changes.useJql", defaultValue = "false")
private boolean useJql;

Expand Down

0 comments on commit b0abb8a

Please sign in to comment.