Skip to content

Commit f646211

Browse files
JianyuWang0623anchao
authored andcommitted
apps/nshlib: Reuse local variable for cmd_memdump
Signed-off-by: wangjianyu3 <[email protected]>
1 parent 339eeaa commit f646211

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

nshlib/nsh_mmcmds.c

+6-7
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ int cmd_free(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
6060
int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
6161
{
6262
FAR char *arg;
63-
int ret;
6463
int i;
6564

6665
arg = lib_get_tempbuffer(LINE_MAX);
@@ -78,10 +77,10 @@ int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
7877
else if (argc >= 2 && (strcmp(argv[1], "-h") == 0 ||
7978
strcmp(argv[1], "help") == 0))
8079
{
81-
ret = nsh_catfile(vtbl, argv[0],
82-
CONFIG_NSH_PROC_MOUNTPOINT "/memdump");
80+
i = nsh_catfile(vtbl, argv[0],
81+
CONFIG_NSH_PROC_MOUNTPOINT "/memdump");
8382
lib_put_tempbuffer(arg);
84-
return ret;
83+
return i;
8584
}
8685
else
8786
{
@@ -95,10 +94,10 @@ int cmd_memdump(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
9594
}
9695
}
9796

98-
ret = nsh_writefile(vtbl, argv[0], arg, strlen(arg),
99-
CONFIG_NSH_PROC_MOUNTPOINT "/memdump");
97+
i = nsh_writefile(vtbl, argv[0], arg, strlen(arg),
98+
CONFIG_NSH_PROC_MOUNTPOINT "/memdump");
10099
lib_put_tempbuffer(arg);
101-
return ret;
100+
return i;
102101
}
103102

104103
#endif /* !CONFIG_NSH_DISABLE_MEMDUMP && NSH_HAVE_WRITEFILE */

0 commit comments

Comments
 (0)