Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request:Add Sink/Flow.forall operator #972

Closed
He-Pin opened this issue Jan 17, 2024 · 4 comments · Fixed by #989
Closed

Feature request:Add Sink/Flow.forall operator #972

He-Pin opened this issue Jan 17, 2024 · 4 comments · Fixed by #989
Labels
t:stream Pekko Streams
Milestone

Comments

@He-Pin
Copy link
Member

He-Pin commented Jan 17, 2024

Motivation:
Add Sink.forall which can be implemented with fold / statefulMap, just act as Nil.forall)

Both zio and fs2 has this method.

Result:
rich operators set, and It works as Java Stream 's allMatch.

@He-Pin He-Pin changed the title Feature request:Add Sink.forall operator Feature request:Add Sink/Flow.forall operator Jan 17, 2024
@He-Pin He-Pin added the t:stream Pekko Streams label Jan 17, 2024
@He-Pin He-Pin added this to the 1.1.0 milestone Jan 17, 2024
@He-Pin
Copy link
Member Author

He-Pin commented Jan 17, 2024

@laglangyue Would you like to take care of this, thanks.

@pjfanning
Copy link
Contributor

pjfanning commented Jan 17, 2024

@laglangyue could you consider filling in an Apache committee form? For larger PRs, we require this. See the CONTRIBUTING.md page on this repo - basically this: https://www.apache.org/licenses/contributor-agreements.html

@laglangyue
Copy link
Contributor

laglangyue commented Jan 18, 2024

Would you like to take care of this, thanks.

willing to do this

could you consider filling in an Apache committee form?

yeah,i will complete it as soon as possible

@laglangyue
Copy link
Contributor

could you consider filling in an Apache committee form?

I had sended it to [email protected]. it's my form
image

@He-Pin He-Pin linked a pull request Jan 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:stream Pekko Streams
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants