Skip to content

Fix potential data race in pendingItem.done()#1347

Merged
nodece merged 3 commits intoapache:masterfrom
gunli:fix-pendingItem-race
Mar 17, 2025
Merged

Fix potential data race in pendingItem.done()#1347
nodece merged 3 commits intoapache:masterfrom
gunli:fix-pendingItem-race

Conversation

@gunli
Copy link
Contributor

@gunli gunli commented Mar 17, 2025

Fixes

Master Issue: #1332

Motivation

Return the buffer to the pool after all callbacks have been called

Modifications

Return the buffer to the pool after all callbacks have been called

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@gunli
Copy link
Contributor Author

gunli commented Mar 17, 2025

@nodece @BewareMyPower

@nodece nodece added this to the v0.15.0 milestone Mar 17, 2025
@nodece nodece merged commit 0ab28c2 into apache:master Mar 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants