Skip to content

Commit f831f7a

Browse files
authored
[Improve] [Connector-V2] Optimize milvus-connector config code (#7658)
1 parent 70ec59c commit f831f7a

File tree

4 files changed

+42
-29
lines changed

4 files changed

+42
-29
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
package org.apache.seatunnel.connectors.seatunnel.milvus.config;
19+
20+
import org.apache.seatunnel.api.configuration.Option;
21+
import org.apache.seatunnel.api.configuration.Options;
22+
23+
public abstract class MilvusCommonConfig {
24+
25+
public static final String CONNECTOR_IDENTITY = "Milvus";
26+
27+
public static final Option<String> URL =
28+
Options.key("url")
29+
.stringType()
30+
.noDefaultValue()
31+
.withDescription("Milvus public endpoint");
32+
33+
public static final Option<String> TOKEN =
34+
Options.key("token")
35+
.stringType()
36+
.noDefaultValue()
37+
.withDescription("Milvus token for authentication");
38+
}

seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSinkConfig.java

+1-15
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,7 @@
2828
import static org.apache.seatunnel.api.sink.DataSaveMode.DROP_DATA;
2929
import static org.apache.seatunnel.api.sink.DataSaveMode.ERROR_WHEN_DATA_EXISTS;
3030

31-
public class MilvusSinkConfig {
32-
33-
public static final String CONNECTOR_IDENTITY = "Milvus";
34-
35-
public static final Option<String> URL =
36-
Options.key("url")
37-
.stringType()
38-
.noDefaultValue()
39-
.withDescription("Milvus public endpoint");
40-
41-
public static final Option<String> TOKEN =
42-
Options.key("token")
43-
.stringType()
44-
.noDefaultValue()
45-
.withDescription("Milvus token for authentication");
31+
public class MilvusSinkConfig extends MilvusCommonConfig {
4632

4733
public static final Option<String> DATABASE =
4834
Options.key("database").stringType().noDefaultValue().withDescription("database");

seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSourceConfig.java

+1-13
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,7 @@
2020
import org.apache.seatunnel.api.configuration.Option;
2121
import org.apache.seatunnel.api.configuration.Options;
2222

23-
public class MilvusSourceConfig {
24-
25-
public static final Option<String> URL =
26-
Options.key("url")
27-
.stringType()
28-
.noDefaultValue()
29-
.withDescription("Milvus public endpoint");
30-
31-
public static final Option<String> TOKEN =
32-
Options.key("token")
33-
.stringType()
34-
.noDefaultValue()
35-
.withDescription("Milvus token for authentication");
23+
public class MilvusSourceConfig extends MilvusCommonConfig {
3624

3725
public static final Option<String> DATABASE =
3826
Options.key("database")

seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/source/MilvusSource.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.apache.seatunnel.api.table.catalog.CatalogTable;
2828
import org.apache.seatunnel.api.table.catalog.TablePath;
2929
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
30+
import org.apache.seatunnel.connectors.seatunnel.milvus.config.MilvusSourceConfig;
3031
import org.apache.seatunnel.connectors.seatunnel.milvus.convert.MilvusConvertUtils;
3132

3233
import java.util.ArrayList;
@@ -77,6 +78,6 @@ public SourceSplitEnumerator<MilvusSourceSplit, MilvusSourceState> restoreEnumer
7778

7879
@Override
7980
public String getPluginName() {
80-
return "Milvus";
81+
return MilvusSourceConfig.CONNECTOR_IDENTITY;
8182
}
8283
}

0 commit comments

Comments
 (0)