diff --git a/java/org/apache/catalina/core/ApplicationHttpRequest.java b/java/org/apache/catalina/core/ApplicationHttpRequest.java index a176e6db7be0..e78495e709d0 100644 --- a/java/org/apache/catalina/core/ApplicationHttpRequest.java +++ b/java/org/apache/catalina/core/ApplicationHttpRequest.java @@ -732,7 +732,12 @@ void parseParameters() { return; } - parameters = new ParameterMap<>(getRequest().getParameterMap()); + Map requestParameters = getRequest().getParameterMap(); + if (requestParameters instanceof ParameterMap) { + parameters = new ParameterMap<>((ParameterMap) requestParameters); + } else { + parameters = new ParameterMap<>(requestParameters); + } mergeParameters(); ((ParameterMap) parameters).setLocked(true); parsedParams = true; diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 2be174ee5967..3e98154f1991 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -123,6 +123,11 @@ attribute value will also be used by the default and WebDAV Servlets. (remm) + + 69285: Optimise the creation of the parameter map for + included requests. Based on sample code and test cases provided by John + Engebretson. (markt) + 69527: Avoid rare cases where a cached resource could be set with 0 content length, or could be evicted immediately. (remm)