Update for support of the ED448 and ED25519 keys and signatures #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrihtarsic Can you rebase this off master as well please? |
|
@coheigea I will do that now and I will close this ticket. Should I create also the JIRA ticket for better traceability on adding the "eddsa-signature feature" to WSS4J or the PR is sufficient? |
|
A JIRA would be great as well, thanks @jrihtarsic |
|
This PR was closed because a new PR 260 addresses this request on main/master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes small updated and basic tests to support EdEC keys for ED448 and ED25519 signatures which are already supported by the xmlsec library.