Fixes PHPCS issues (#262)

Author: kedarkhaire

modules/apigee_graphql_doc/src/Controller/ApigeeGraphqlServerController.php

@@ -29,9 +29,6 @@
 use Drupal\file\Entity\File;
 use Drupal\node\NodeInterface;
 use GraphQL\GraphQL;
-use GraphQL\Type\Definition\ObjectType;
-use GraphQL\Type\Definition\Type;
-use GraphQL\Type\Schema;
 use GraphQL\Utils\BuildSchema;
 use Symfony\Component\HttpFoundation\JsonResponse;
 
@@ -55,7 +52,7 @@ public function build(NodeInterface $node) {
       $field_graphql_spec = $node->get('field_graphql_spec');
 
       if ($field_graphql_spec && $field_graphql_spec->target_id) {
-        /* @var \Drupal\file\Entity\File $file */
+        /** @var \Drupal\file\Entity\File $file */
         $file = File::load($field_graphql_spec->target_id);
 
         if ($file) {

modules/apigee_graphql_doc/src/Plugin/Field/FieldFormatter/GraphiqlFormatter.php

@@ -92,9 +92,9 @@ private function attachLibraries(array $element, array $graphql_urls) {
           'apigeeGraphqlDocFormatter' => [
             $this->fieldDefinition->getName() => [
               'graphqlUrls' => $graphql_urls,
-            ]
-          ]
-        ]
+            ],
+          ],
+        ],
       ];
     }
     return $element;

src/Entity/Form/ApiDocReimportSpecForm.php

@@ -19,7 +19,6 @@
 
 namespace Drupal\apigee_api_catalog\Entity\Form;
 
-use Drupal\apigee_api_catalog\SpecFetcherInterface;
 use Drupal\Component\Datetime\TimeInterface;
 use Drupal\Core\Access\AccessResult;
 use Drupal\Core\Entity\ContentEntityConfirmFormBase;
@@ -30,6 +29,7 @@
 use Drupal\Core\Routing\RouteMatchInterface;
 use Drupal\Core\Session\AccountInterface;
 use Drupal\Core\Url;
+use Drupal\apigee_api_catalog\SpecFetcherInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
@@ -135,7 +135,7 @@ public function getDescription() {
    * {@inheritdoc}
    */
   public function submitForm(array &$form, FormStateInterface $form_state) {
-    /* @var \Drupal\node\NodeInterface $entity */
+    /** @var \Drupal\node\NodeInterface $entity */
     $entity = $this->getEntity();
 
     if ($entity->get('field_apidoc_spec_file_source')->value != SpecFetcherInterface::SPEC_AS_URL) {

src/Plugin/Field/FieldFormatter/SmartDocsFormatter.php

@@ -19,13 +19,10 @@
 
 namespace Drupal\apigee_api_catalog\Plugin\Field\FieldFormatter;
 
-use Drupal\Component\Serialization\Exception\InvalidDataTypeException;
-use Drupal\Component\Serialization\Json;
 use Drupal\Core\Field\FieldDefinitionInterface;
 use Drupal\Core\Field\FieldItemListInterface;
 use Drupal\Core\Logger\LoggerChannelFactoryInterface;
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
-use Drupal\Core\Serialization\Yaml;
 use Drupal\file\Plugin\Field\FieldFormatter\FileFormatterBase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
@@ -133,7 +130,7 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
       'library' => [
         'apigee_api_catalog/js_yaml',
         'apigee_api_catalog/smartdocs_integration',
-        'apigee_api_catalog/smartdocs'
+        'apigee_api_catalog/smartdocs',
       ],
     ];
 

src/Plugin/Validation/Constraint/ApiDocFileLinkConstraintValidator.php

@@ -88,7 +88,7 @@ public function validate($items, Constraint $constraint) {
         ];
 
         // Perform only a HEAD method to save bandwidth.
-        /* @var $response \Psr\Http\Message\ResponseInterface */
+        /** @var \Psr\Http\Message\ResponseInterface $response */
         $response = $this->httpClient->head($url, $options);
       }
       catch (RequestException $request_exception) {

src/SpecFetcher.php

@@ -32,8 +32,8 @@
 use GuzzleHttp\ClientInterface;
 use GuzzleHttp\Exception\GuzzleException;
 use GuzzleHttp\Psr7\Request;
-use Psr\Log\LoggerInterface;
 use Psr\Log\LogLevel;
+use Psr\Log\LoggerInterface;
 
 /**
  * Class SpecFetcher.
@@ -108,7 +108,7 @@ public function fetchSpec(NodeInterface $apidoc): string {
     if ($apidoc->get('field_apidoc_spec_file_source')->value === static::SPEC_AS_URL) {
 
       // If the file_link field is empty, return without changes.
-      // TODO: The file link shouldn't be empty. Consider throwing an error.
+      // @todo The file link shouldn't be empty. Consider throwing an error.
       if ($apidoc->get('field_apidoc_file_link')->isEmpty()) {
         return FALSE;
       }

src/UpdateService.php

@@ -28,7 +28,6 @@
 use Drupal\Core\Entity\EntityLastInstalledSchemaRepositoryInterface;
 use Drupal\Core\Entity\EntityTypeManagerInterface;
 use Drupal\Core\Extension\ModuleHandlerInterface;
-use Drupal\Core\Field\BaseFieldDefinition;
 use Drupal\Core\Utility\UpdateException;
 use Drupal\field\Entity\FieldConfig;
 use Drupal\field\Entity\FieldStorageConfig;

tests/src/Functional/ApiDocsAdminTest.php

@@ -22,10 +22,10 @@
 
 use Drupal\Component\Render\FormattableMarkup;
 use Drupal\Core\Url;
-use Drupal\file\Entity\File;
-use Drupal\file\FileInterface;
 use Drupal\Tests\BrowserTestBase;
 use Drupal\Tests\TestFileCreationTrait;
+use Drupal\file\Entity\File;
+use Drupal\file\FileInterface;
 
 /**
  * Simple test to ensure that main page loads with module enabled.
@@ -50,7 +50,7 @@ class ApiDocsAdminTest extends BrowserTestBase {
     'views',
     'apigee_api_catalog',
     'block',
-    'field_ui'
+    'field_ui',
   ];
 
   /**
@@ -144,7 +144,7 @@ public function testApiDocAdministration() {
     $assert->pageTextContains(new FormattableMarkup(
         'OpenAPI Doc @name has been created.',
         [
-          '@name' => $random_name
+          '@name' => $random_name,
         ]
       )
     );

tests/src/Kernel/ApidocEntityTest.php

@@ -114,7 +114,7 @@ public function testEntity() {
    * Test revisioning functionality on an apidocs entity.
    */
   public function testRevisions() {
-    /* @var \Drupal\node\NodeInterface $entity */
+    /** @var \Drupal\node\NodeInterface $entity */
 
     $description_v1 = 'Test API';
     $entity = $this->nodeStorage->create([