#80 Upgrade path from API doc custom entities to nodes (#85)

* [#71] Create apidoc node bundle on install/update.

* [#71] Apidoc conversion.

* [#71] Apidoc conversion.

* [#71] Apidoc conversion.

* [#71] Apidoc - node path aliases.

* [#71] Apidoc - tests.

* [#71] Apidoc - README.

* [#71] Apidoc - links/tasks/actions.

* [#71] Apidoc - ApiDocsAdminTest.

* [#71] Apidoc - ApiDocsJsonApi.

* [#71] Apidoc - removing ApiDocsAccessTest as it is covered by core.

* [#80] Allow updating from 1.x branch, and import config to create node type and fields, etc.

* [#80] Moving logic to an update service.

* [#80] Update step 8802 successful.

* [#80] Update steps complete correctly.

* [#80] Code sniffer fixes.

* [#80] Fieldname and values fix.

* [#80] Remove some merged code.

* [#80] Fixes from the scenario where 1.x was never installed.

Author: arlina-espinoza

README.md

@@ -47,8 +47,6 @@ https://www.drupal.org/node/3058344
 
 ### Known issues
 
-- [Backwards compatibility with the version 1.x of this module is a separate issue](https://github.com/apigee/apigee-api-catalog-drupal/issues/80), you can subscribe to notifications to follow the status.
-
 - The Apigee SmartDocs formatter can only render one OpenAPI spec per page and the URL pattern
   must match `/api/{entityId}`.  This means that the formatter will probably not work correctly if
   you modify the default API Docs view or try to use this file Formatter on other node types or entities.

apigee_api_catalog.install

@@ -38,22 +38,6 @@ function apigee_api_catalog_requirements($phase) {
     ];
   }
 
-  // Prevent updating the module from 1.x, as there is no update path yet.
-  // @see https://github.com/apigee/apigee-api-catalog-drupal/issues/80
-  $schemaVersion = \Drupal::keyValue('system.schema')->get('apigee_api_catalog');
-  if (in_array($phase, ['update', 'runtime']) && $schemaVersion < 8801) {
-    return [
-      'apigee_api_catalog_update_unsupported' => [
-        'title' => t('Apigee API Catalog'),
-        'description' =>t('The <a href=":link_module">Apigee API Catalog</a> 1.x version is enabled on this site but the module has been replaced with a 2.x version on the filesystem. Currently there is no way to upgrade from 1.x to 2.x. You will need to revert to the latest 1.x version of the module or uninstall the Apigee API Catalog module which will remove the module\'s current content and configuration then install the 2.x version. If you want to upgrade you will need to follow <a href=":link_issue">issue #80</a> for updates on the upgrade path functionality.', [
-          ':link_module' => 'https://github.com/apigee/apigee-api-catalog-drupal/issues/80',
-          ':link_issue' => 'https://github.com/apigee/apigee-api-catalog-drupal/issues/80',
-        ]),
-        'severity' => REQUIREMENT_ERROR,
-      ],
-    ];
-  }
-
   return [];
 }
 
@@ -108,3 +92,31 @@ function apigee_api_catalog_update_8701() {
 function apigee_api_catalog_update_8801() {
   // Empty - only needed to set the 2.x module schema number.
 }
+
+/**
+ * Create API Doc node type and fields if updating from 1.x.
+ */
+function apigee_api_catalog_update_8802() {
+  return \Drupal::service('apigee_api_catalog.updates')->update8802();
+}
+
+/**
+ * Recreate other fields added to the API Doc entity onto the API Doc node type if updating from 1.x.
+ */
+function apigee_api_catalog_update_8803() {
+  return \Drupal::service('apigee_api_catalog.updates')->update8803();
+}
+
+/**
+ * Convert API Doc entities to nodes (migrating data) if updating from 1.x.
+ */
+function apigee_api_catalog_update_8804(&$sandbox) {
+  return \Drupal::service('apigee_api_catalog.updates')->update8804($sandbox);
+}
+
+/**
+ * Delete API Doc entity definition if updating from 1.x.
+ */
+function apigee_api_catalog_update_8805() {
+  return \Drupal::service('apigee_api_catalog.updates')->update8805();
+}

apigee_api_catalog.services.yml

@@ -13,3 +13,7 @@ services:
     arguments: ['@path.matcher', '@path.validator']
     tags:
       - { name: event_subscriber }
+
+  apigee_api_catalog.updates:
+    class: Drupal\apigee_api_catalog\UpdateService
+    arguments: ['@uuid', '@config.factory', '@module_handler', '@entity_type.manager', '@entity_field.manager', '@entity.last_installed_schema.repository']