Improved tests for event dispatcher

- Adding some cases, and fixed workflow

Author: mmoreram

AsyncEventDispatcher.php

@@ -63,21 +63,14 @@ protected function doAsyncDispatch(
     ) {
         $promise = new FulfilledPromise();
         foreach ($listeners as $listener) {
-            if ($event->isPropagationStopped()) {
-                break;
-            }
-
-            $result = $listener($event, $eventName, $this);
-            if (!$result instanceof PromiseInterface) {
-                $result = new FulfilledPromise($result);
-            }
-
-            $promise = $promise->then(function () use ($result) {
-                return new FulfilledPromise(function (PromiseEvent $event) use ($result) {
-                    return $event->hasPromise()
-                        ? new FulfilledPromise()
-                        : $result;
-                });
+            $promise = $promise->then(function () use ($event, $eventName, $listener) {
+                return
+                    (new FulfilledPromise())
+                        ->then(function () use ($event, $eventName, $listener) {
+                            return $event->isPropagationStopped()
+                                ? new FulfilledPromise()
+                                : $listener($event, $eventName, $this);
+                        });
             });
         }
 

BaseBundle/BaseAsyncKernel.php

@@ -15,11 +15,11 @@
 
 namespace Symfony\Component\HttpKernel\Tests;
 
+use Mmoreram\BaseBundle\Kernel\AsyncBaseKernel;
 use Mmoreram\BaseBundle\Tests\BaseFunctionalTest;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 use Symfony\Component\HttpKernel\AsyncEventDispatcher;
 use Symfony\Component\HttpKernel\AsyncHttpKernel;
-use Symfony\Component\HttpKernel\BaseBundle\BaseAsyncKernel;
 use Symfony\Component\HttpKernel\KernelInterface;
 
 /**
@@ -91,7 +91,7 @@ protected static function getKernel(): KernelInterface
             ],
         ];
 
-        return new BaseAsyncKernel(
+        return new AsyncBaseKernel(
             [
                 FrameworkBundle::class,
             ],

Tests/AsyncKernelFunctionalTest.php

@@ -0,0 +1,104 @@
+<?php
+
+/*
+ * This file is part of the Symfony Async Kernel
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * Feel free to edit as you please, and have fun.
+ *
+ * @author Marc Morera <yuhu@mmoreram.com>
+ */
+
+declare(strict_types=1);
+
+namespace Symfony\Component\HttpKernel\Tests;
+
+use Clue\React\Block;
+use React\EventLoop\StreamSelectLoop;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+/**
+ * Class GetResponsesPromiseFunctionalMidPromiseTest.
+ */
+class GetResponsesPromiseFunctionalMidPromiseTest extends AsyncKernelFunctionalTest
+{
+    /**
+     * Decorate configuration.
+     *
+     * @param array $configuration
+     *
+     * @return array
+     */
+    protected static function decorateConfiguration(array $configuration): array
+    {
+        $configuration = parent::decorateConfiguration($configuration);
+        $configuration['services']['listener'] = [
+            'class' => Listener::class,
+            'tags' => [
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromise1',
+                ],
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromise2',
+                ],
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromise1',
+                ],
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromiseA',
+                ],
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromise2',
+                ],
+                [
+                    'name' => 'kernel.event_listener',
+                    'event' => 'kernel.async_request',
+                    'method' => 'handleGetResponsePromise3',
+                ],
+            ],
+        ];
+
+        return $configuration;
+    }
+
+    /**
+     * Everything should work as before in the world of sync requests.
+     */
+    public function testSyncKernel()
+    {
+        $loop = new StreamSelectLoop();
+        $request = new Request([], [], [], [], [], [
+            'REQUEST_METHOD' => 'GET',
+            'REQUEST_URI' => '/promise',
+        ]);
+
+        $_GET['partial'] = '';
+        $promise = self::$kernel
+            ->handleAsync($request)
+            ->then(function (Response $response) {
+                $this->assertEquals(
+                    'A',
+                    $response->getContent()
+                );
+
+                $this->assertEquals('121', $_GET['partial']);
+            });
+
+        $loop->run();
+        Block\await($promise, $loop);
+        $this->assertEquals('121', $_GET['partial']);
+    }
+}