fix clippy warnings

Author: lrlna

crates/apollo-parser/src/ast/node_ext.rs

@@ -1,3 +1,7 @@
+// This lint is here as we don't really need users to convert String/i64/f64
+// into an AST Node. Should this change, we can remove this lint again.
+#![allow(clippy::from_over_into)]
+
 use crate::{ast, ast::AstNode, SyntaxNode, TokenText};
 
 impl ast::Name {

crates/apollo-parser/src/error.rs

@@ -12,15 +12,13 @@ use std::fmt;
 /// ```rust
 /// use apollo_parser::Parser;
 ///
-/// fn main() {
-///     let input = "union SearchResult = Photo | Person | Cat | Dog";
-///     let parser = Parser::new(input);
-///     let ast = parser.parse();
+/// let input = "union SearchResult = Photo | Person | Cat | Dog";
+/// let parser = Parser::new(input);
+/// let ast = parser.parse();
 ///
-///     assert!(ast.errors().is_empty());
+/// assert!(ast.errors().is_empty());
 ///
-///     let doc = ast.document();
-/// }
+/// let doc = ast.document();
 /// ```
 ///
 /// `Error` struct does not at the moment implement `Display`. We encourage you

crates/apollo-parser/src/lib.rs

@@ -47,30 +47,26 @@
 //! ```rust
 //! use apollo_parser::Parser;
 //!
-//! fn main() {
-//!     let input = "union SearchResult = Photo | Person | Cat | Dog";
-//!     let parser = Parser::new(input);
-//!     let ast = parser.parse();
-//! }
+//! let input = "union SearchResult = Photo | Person | Cat | Dog";
+//! let parser = Parser::new(input);
+//! let ast = parser.parse();
 //! ```
 //!
 //! `apollo-parser` is built to be error-resilient. This means we don't abort parsing (or lexing) if an error occurs. That means `parser.parse()` will always produce an AST, and it will be accompanied by any errors that are encountered:
 //!
 //! ```rust
 //! use apollo_parser::Parser;
 //!
-//! fn main() {
-//!     let input = "union SearchResult = Photo | Person | Cat | Dog";
-//!     let parser = Parser::new(input);
-//!     let ast = parser.parse();
+//! let input = "union SearchResult = Photo | Person | Cat | Dog";
+//! let parser = Parser::new(input);
+//! let ast = parser.parse();
 //!
-//!     // ast.errors() returns an errors slice encountered during lexing and parsing
-//!     assert!(ast.errors().is_empty());
+//! // ast.errors() returns an errors slice encountered during lexing and parsing
+//! assert!(ast.errors().is_empty());
 //!
-//!     // ast.document() get the Document, or root node, of the tree that you can
-//!     // start iterating on.
-//!     let doc = ast.document();
-//! }
+//! // ast.document() get the Document, or root node, of the tree that you can
+//! // start iterating on.
+//! let doc = ast.document();
 //! ```
 //!
 //! ### Examples
@@ -90,25 +86,23 @@
 //! ```rust
 //! use apollo_parser::{ast, Parser};
 //!
-//! fn main() {
-//!     let input = "
-//!     type ProductDimension {
-//!       size: String
-//!       weight: Float @tag(name: \"hi from inventory value type field\")
-//!     }
-//!     ";
-//!     let parser = Parser::new(input);
-//!     let ast = parser.parse();
-//!     assert!(ast.errors().is_empty());
-//!   
-//!     let doc = ast.document();
-//!   
-//!     for def in doc.definitions() {
-//!         if let ast::Definition::ObjectTypeDefinition(object_type) = def {
-//!             assert_eq!(object_type.name().unwrap().text(), "ProductDimension");
-//!             for field_def in object_type.fields_definition().unwrap().field_definitions() {
-//!                 println!("{}", field_def.name().unwrap().text()); // size weight
-//!             }
+//! let input = "
+//! type ProductDimension {
+//!   size: String
+//!   weight: Float @tag(name: \"hi from inventory value type field\")
+//! }
+//! ";
+//! let parser = Parser::new(input);
+//! let ast = parser.parse();
+//! assert!(ast.errors().is_empty());
+//!
+//! let doc = ast.document();
+//!
+//! for def in doc.definitions() {
+//!     if let ast::Definition::ObjectTypeDefinition(object_type) = def {
+//!         assert_eq!(object_type.name().unwrap().text(), "ProductDimension");
+//!         for field_def in object_type.fields_definition().unwrap().field_definitions() {
+//!             println!("{}", field_def.name().unwrap().text()); // size weight
 //!         }
 //!     }
 //! }
@@ -119,39 +113,37 @@
 //! ```rust
 //! use apollo_parser::{ast, Parser};
 //!
-//! fn main() {
-//!     let input = "
-//!     query GraphQuery($graph_id: ID!, $variant: String) {
-//!       service(id: $graph_id) {
-//!         schema(tag: $variant) {
-//!           document
-//!         }
-//!       }
+//! let input = "
+//! query GraphQuery($graph_id: ID!, $variant: String) {
+//!   service(id: $graph_id) {
+//!     schema(tag: $variant) {
+//!       document
 //!     }
-//!     ";
-//!     
-//!     let parser = Parser::new(input);
-//!     let ast = parser.parse();
-//!     assert!(&ast.errors().is_empty());
-//!     
-//!     let doc = ast.document();
-//!     
-//!     for def in doc.definitions() {
-//!         if let ast::Definition::OperationDefinition(op_def) = def {
-//!             assert_eq!(op_def.name().unwrap().text(), "GraphQuery");
-//!     
-//!             let variable_defs = op_def.variable_definitions();
-//!             let variables: Vec<String> = variable_defs
-//!                 .iter()
-//!                 .map(|v| v.variable_definitions())
-//!                 .flatten()
-//!                 .filter_map(|v| Some(v.variable()?.text().to_string()))
-//!                 .collect();
-//!             assert_eq!(
-//!                 variables.as_slice(),
-//!                 ["graph_id".to_string(), "variant".to_string()]
-//!             );
-//!         }
+//!   }
+//! }
+//! ";
+//!
+//! let parser = Parser::new(input);
+//! let ast = parser.parse();
+//! assert!(&ast.errors().is_empty());
+//!
+//! let doc = ast.document();
+//!
+//! for def in doc.definitions() {
+//!     if let ast::Definition::OperationDefinition(op_def) = def {
+//!         assert_eq!(op_def.name().unwrap().text(), "GraphQuery");
+//!
+//!         let variable_defs = op_def.variable_definitions();
+//!         let variables: Vec<String> = variable_defs
+//!             .iter()
+//!             .map(|v| v.variable_definitions())
+//!             .flatten()
+//!             .filter_map(|v| Some(v.variable()?.text().to_string()))
+//!             .collect();
+//!         assert_eq!(
+//!             variables.as_slice(),
+//!             ["graph_id".to_string(), "variant".to_string()]
+//!         );
 //!     }
 //! }
 //! ```

crates/apollo-parser/src/parser/generated/syntax_kind.rs

@@ -5,7 +5,8 @@
     bad_style,
     missing_docs,
     unreachable_pub,
-    clippy::manual_non_exhaustive
+    clippy::manual_non_exhaustive,
+    clippy::upper_case_acronyms
 )]
 #[doc = r" A token generated by the `Parser`."]
 #[non_exhaustive]

crates/apollo-parser/src/parser/grammar/enum_.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 use crate::{
     parser::grammar::{description, directive, name, value},
     Parser, SyntaxKind, TokenKind, S, T,

crates/apollo-parser/src/parser/grammar/field.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 use crate::{
     parser::grammar::{argument, description, directive, name, selection, ty},
     Parser, SyntaxKind, TokenKind, S, T,

crates/apollo-parser/src/parser/grammar/object.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 use crate::{
     parser::grammar::{description, directive, document::is_definition, field, name, ty},
     Parser, SyntaxKind, TokenKind, S, T,

crates/apollo-parser/src/parser/grammar/union_.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 use crate::{
     parser::grammar::{description, directive, document::is_definition, name, ty},
     Parser, SyntaxKind, TokenKind, S, T,

crates/apollo-parser/src/parser/grammar/value.rs

@@ -126,7 +126,7 @@ pub(crate) fn object_field(p: &mut Parser) {
             value(p);
             if p.peek().is_some() {
                 guard.finish_node();
-                return object_field(p);
+                object_field(p)
             }
         }
     }

xtask/src/codegen/gen_syntax_kinds.rs

@@ -58,7 +58,7 @@ pub(crate) fn generate_kinds(kinds: KindsSrc<'_>) -> Result<String> {
         .collect::<Vec<_>>();
 
     let ast = quote! {
-        #![allow(bad_style, missing_docs, unreachable_pub, clippy::manual_non_exhaustive)]
+        #![allow(bad_style, missing_docs, unreachable_pub, clippy::manual_non_exhaustive, clippy::upper_case_acronyms)]
         /// A token generated by the `Parser`.
         #[non_exhaustive]
         #[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash, Debug)]