Resolve comments

Author: flowguru

fdbclient/GlobalConfig.actor.cpp

@@ -153,9 +153,6 @@ void GlobalConfig::erase(KeyRangeRef range) {
 	}
 }
 
-// Updates local copy of global configuration by reading the entire key-range
-// from storage (proxied through the GrvProxies). Returns the version of the
-// refreshed data.
 ACTOR Future<Version> GlobalConfig::refresh(GlobalConfig* self, Version lastKnown, Version largestSeen) {
 	// TraceEvent trace(SevInfo, "GlobalConfigRefresh");
 	self->erase(KeyRangeRef(""_sr, "\xff"_sr));
@@ -233,7 +230,7 @@ ACTOR Future<Void> GlobalConfig::updater(GlobalConfig* self, const ClientDBInfo*
 									} else if (mutation.type == MutationRef::ClearRange) {
 										self->erase(KeyRangeRef(mutation.param1, mutation.param2));
 									} else {
-										ASSERT(false);
+										UNREACHABLE();
 									}
 								}
 

fdbclient/include/fdbclient/GlobalConfig.actor.h

@@ -163,6 +163,9 @@ class GlobalConfig : NonCopyable {
 	// of the global configuration keyspace.
 	void erase(KeyRangeRef range);
 
+	// Updates local copy of global configuration by reading the entire key-range
+	// from storage (proxied through the GrvProxies). Returns the version of the
+	// refreshed data.
 	ACTOR static Future<Version> refresh(GlobalConfig* self, Version lastKnown, Version largestSeen);
 	ACTOR static Future<Void> updater(GlobalConfig* self, const ClientDBInfo* dbInfo);