Fix 5.8 warnings

Author: dnadoba

Sources/X509/CertificatePrivateKey.swift

@@ -14,6 +14,7 @@
 
 @preconcurrency import Crypto
 @preconcurrency import _CryptoExtras
+import Foundation
 
 extension Certificate {
     /// A private key that can be used with a certificate.

Sources/X509/CertificatePublicKey.swift

@@ -15,6 +15,7 @@
 import SwiftASN1
 @preconcurrency import Crypto
 @preconcurrency import _CryptoExtras
+import Foundation
 
 extension Certificate {
     /// A public key that can be used with a certificate.

Sources/X509/DistinguishedNameBuilder/CommonName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Common Name (CN) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/CountryName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Country Name (C) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/LocalityName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Locality Name (L) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/OrganizationName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Organization Name (O) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/OrganizationalUnitName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Organizational Unit Name (OU) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/StateOrProvinceName.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the State or Province Name (ST) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/DistinguishedNameBuilder/StreetAddress.swift

@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+import SwiftASN1
+
 /// Set the Street Address (STREET) of a ``DistinguishedName``.
 ///
 /// This type is used in ``DistinguishedNameBuilder`` contexts.

Sources/X509/OCSP/OCSPPolicy.swift

@@ -77,7 +77,7 @@ enum OCSPRequestHashAlgorithm {
     }
 }
 
-public struct OCSPVerifierPolicy<Requester: OCSPRequester>: VerifierPolicy {
+public struct OCSPVerifierPolicy<Requester: OCSPRequester>: VerifierPolicy, Sendable {
 
     private var requester: Requester
     private var requestHashAlgorithm: OCSPRequestHashAlgorithm
@@ -303,7 +303,7 @@ extension OCSPSingleResponse {
 ///   - maxDuration: max execution duration in seconds of `operation`
 ///   - operation: the task to start and cancel after `maxDuration` seconds
 /// - Returns: the result of `operation`
-private func withTimeout<Result>(
+private func withTimeout<Result: Sendable>(
     _ maxDuration: TimeInterval,
     operation: @escaping @Sendable () async -> Result
 ) async -> Result {

Sources/X509/Signature.swift

@@ -15,6 +15,7 @@
 import SwiftASN1
 @preconcurrency import Crypto
 @preconcurrency import _CryptoExtras
+import Foundation
 
 extension Certificate {
     /// An abstract representation of the cryptographic signature on a certificate.

Sources/X509/Verifier/VerifierPolicy.swift

@@ -16,7 +16,7 @@ public protocol VerifierPolicy {
     mutating func chainMeetsPolicyRequirements(chain: UnverifiedCertificateChain) async -> PolicyEvaluationResult
 }
 
-public enum PolicyEvaluationResult {
+public enum PolicyEvaluationResult: Sendable {
     case meetsPolicy
     case failsToMeetPolicy(reason: String)
 }

Tests/X509Tests/DistinguishedNameTests.swift

@@ -159,7 +159,7 @@ final class DistinguishedNameTests: XCTestCase {
                 StateOrProvinceName("DigiLand")
             }
 
-            for name in ["foo", "bar", "baz"].filter { $0 == "baz" } {
+            for name in ["foo", "bar", "baz"].filter({ $0 == "baz" }) {
                 CommonName(name)
             }
         }

Tests/X509Tests/OCSPPolicyVerifierTests.swift

@@ -171,6 +171,7 @@ final class OCSPVerifierPolicyTests: XCTestCase {
     }
 
     func testSingleCertWithOCSP() async {
+        let now = self.now
         await self.assertChainMeetsPolicy(
             chain: Self.chainWithSingleCertWithOCSP,
             requester: .noThrow { request, uri -> OCSPResponse in
@@ -182,14 +183,15 @@ final class OCSPVerifierPolicyTests: XCTestCase {
                 return .successful(.signed(responses: [OCSPSingleResponse(
                     certID: singleRequest.certID,
                     certStatus: .good,
-                    thisUpdate: try .init(self.now - .days(1)),
-                    nextUpdate: try .init(self.now + .days(1))
+                    thisUpdate: try .init(now - .days(1)),
+                    nextUpdate: try .init(now + .days(1))
                 )], responseExtensions: { nonce }))
             }
         )
     }
 
     func testWrongNonce() async {
+        let now = self.now
         await self.assertChainFailsToMeetPolicy(
             chain: Self.chainWithSingleCertWithOCSP,
             requester: .noThrow { request, uri -> OCSPResponse in
@@ -201,14 +203,15 @@ final class OCSPVerifierPolicyTests: XCTestCase {
                 return .successful(.signed(responses: [OCSPSingleResponse(
                     certID: singleRequest.certID,
                     certStatus: .good,
-                    thisUpdate: try .init(self.now - .days(1)),
-                    nextUpdate: try .init(self.now + .days(1))
+                    thisUpdate: try .init(now - .days(1)),
+                    nextUpdate: try .init(now + .days(1))
                 )], responseExtensions: { OCSPNonce() }))
             }
         )
     }
 
     func testRevokedCert() async {
+        let now = self.now
         await self.assertChainFailsToMeetPolicy(
             chain: Self.chainWithSingleCertWithOCSP,
             requester: .noThrow { request, uri -> OCSPResponse in
@@ -220,17 +223,18 @@ final class OCSPVerifierPolicyTests: XCTestCase {
                 return .successful(.signed(responses: [OCSPSingleResponse(
                     certID: singleRequest.certID,
                     certStatus: .revoked(.init(
-                        revocationTime: try .init(self.now),
+                        revocationTime: try .init(now),
                         revocationReason: .unspecified
                     )),
-                    thisUpdate: try .init(self.now - .days(1)),
-                    nextUpdate: try .init(self.now + .days(1))
+                    thisUpdate: try .init(now - .days(1)),
+                    nextUpdate: try .init(now + .days(1))
                 )], responseExtensions: { nonce }))
             }
         )
     }
 
     func testResponseDoesNotIncludeResponseForRequestedCert() async {
+        let now = self.now
         await self.assertChainFailsToMeetPolicy(
             chain: Self.chainWithSingleCertWithOCSP,
             requester: .noThrow { request, uri -> OCSPResponse in
@@ -246,8 +250,8 @@ final class OCSPVerifierPolicyTests: XCTestCase {
                         serialNumber: .init()
                     ),
                     certStatus: .good,
-                    thisUpdate: try .init(self.now - .days(1)),
-                    nextUpdate: try .init(self.now + .days(1))
+                    thisUpdate: try .init(now - .days(1)),
+                    nextUpdate: try .init(now + .days(1))
                 )], responseExtensions: { nonce }))
             }
         )