Remove localizedDescription (#173)

Part of apple/swift-openapi-generator#868

Refactors `error.localizedDescription` to `"\(error)"` to prevent
linking Foundation. This will change the error strings as can be seen in
the tests. Alternatively, we would split the implementation by a trait
`FullFoundationSupport`. Where that would use `localizedDescription`

Author: madsodgaard

Sources/OpenAPIRuntime/Conversion/ErrorExtensions.swift

@@ -124,7 +124,7 @@ struct MultiError: Swift.Error, LocalizedError, CustomStringConvertible {
 
     var errorDescription: String? {
         if let first = errors.first {
-            return "Multiple errors encountered, first one: \(first.localizedDescription)."
+            return "Multiple errors encountered, first one: \(first)."
         } else {
             return "No errors"
         }

Sources/OpenAPIRuntime/Errors/ClientError.swift

@@ -127,6 +127,6 @@ extension ClientError: LocalizedError {
     ///
     /// - Returns: A localized string describing the client error.
     public var errorDescription: String? {
-        "Client encountered an error invoking the operation \"\(operationID)\", caused by \"\(causeDescription)\", underlying error: \(underlyingError.localizedDescription)."
+        "Client encountered an error invoking the operation \"\(operationID)\", caused by \"\(causeDescription)\", underlying error: \(underlyingError)."
     }
 }

Sources/OpenAPIRuntime/Errors/ServerError.swift

@@ -173,6 +173,6 @@ extension ServerError: LocalizedError {
     ///
     /// - Returns: A localized string describing the server error.
     public var errorDescription: String? {
-        "Server encountered an error handling the operation \"\(operationID)\", caused by \"\(causeDescription)\", underlying error: \(underlyingError.localizedDescription)."
+        "Server encountered an error handling the operation \"\(operationID)\", caused by \"\(causeDescription)\", underlying error: \(underlyingError)."
     }
 }

Tests/OpenAPIRuntimeTests/Errors/Test_ClientError.swift

@@ -12,6 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+import Foundation
 import HTTPTypes
 @_spi(Generated) @testable import OpenAPIRuntime
 import XCTest
@@ -36,7 +37,7 @@ final class Test_ServerError: XCTestCase {
         )
         XCTAssertEqual(
             error.localizedDescription,
-            "Server encountered an error handling the operation \"op\", caused by \"User handler threw an error.\", underlying error: Just errorDescription."
+            "Server encountered an error handling the operation \"op\", caused by \"User handler threw an error.\", underlying error: Just description."
         )
     }
 }

Tests/OpenAPIRuntimeTests/Errors/Test_RuntimeError.swift

@@ -12,6 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+import Foundation
 import HTTPTypes
 @_spi(Generated) @testable import OpenAPIRuntime
 import XCTest

Tests/OpenAPIRuntimeTests/Errors/Test_ServerError.swift

@@ -12,6 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+import Foundation
 import HTTPTypes
 @_spi(Generated) @testable import OpenAPIRuntime
 import XCTest
@@ -31,7 +32,7 @@ final class Test_ClientError: XCTestCase {
         )
         XCTAssertEqual(
             error.localizedDescription,
-            "Client encountered an error invoking the operation \"op\", caused by \"Transport threw an error.\", underlying error: Just errorDescription."
+            "Client encountered an error invoking the operation \"op\", caused by \"Transport threw an error.\", underlying error: Just description."
         )
     }
 }