Disable "respectsExistingLineBreaks" in .swift-format for more consistent styling (#20)

### Motivation

- Relates to
[#230](apple/swift-openapi-generator#230)

### Modifications

- Disable respectsExistingLineBreaks .swift-format rule and address
changes requested

### Result

- One of the .swift-format rules will be disabled

### Test Plan

- Run Tests

Co-authored-by: Honza Dvorsky <[email protected]>

Author: PARAIPAN9

.swift-format

@@ -14,7 +14,7 @@
   "lineLength" : 120,
   "maximumBlankLines" : 1,
   "prioritizeKeepingFunctionOutputTogether" : false,
-  "respectsExistingLineBreaks" : true,
+  "respectsExistingLineBreaks" : false,
   "rules" : {
     "AllPublicDeclarationsHaveDocumentation" : true,
     "AlwaysUseLowerCamelCase" : false,

Sources/OpenAPIURLSession/URLSessionTransport.swift

@@ -74,19 +74,15 @@ public struct URLSessionTransport: ClientTransport {
         /// Creates a new configuration with the provided session.
         /// - Parameter session: The URLSession used for performing HTTP operations.
         ///     If none is provided, the system uses the shared URLSession.
-        public init(session: URLSession = .shared) {
-            self.session = session
-        }
+        public init(session: URLSession = .shared) { self.session = session }
     }
 
     /// A set of configuration values used by the transport.
     public var configuration: Configuration
 
     /// Creates a new URLSession-based transport.
     /// - Parameter configuration: A set of configuration values used by the transport.
-    public init(configuration: Configuration = .init()) {
-        self.configuration = configuration
-    }
+    public init(configuration: Configuration = .init()) { self.configuration = configuration }
 
     /// Asynchronously sends an HTTP request and returns the response and body.
     ///
@@ -97,20 +93,13 @@ public struct URLSessionTransport: ClientTransport {
     ///   - operationID: An optional identifier for the operation or request.
     /// - Returns: A tuple containing the HTTP response and an optional HTTP response body.
     /// - Throws: An error if there is a problem sending the request or processing the response.
-    public func send(
-        _ request: HTTPRequest,
-        body: HTTPBody?,
-        baseURL: URL,
-        operationID: String
-    ) async throws -> (HTTPResponse, HTTPBody?) {
+    public func send(_ request: HTTPRequest, body: HTTPBody?, baseURL: URL, operationID: String) async throws -> (
+        HTTPResponse, HTTPBody?
+    ) {
         // TODO: https://github.com/apple/swift-openapi-generator/issues/301
         let urlRequest = try await URLRequest(request, body: body, baseURL: baseURL)
         let (responseBody, urlResponse) = try await invokeSession(urlRequest)
-        return try HTTPResponse.response(
-            method: request.method,
-            urlResponse: urlResponse,
-            data: responseBody
-        )
+        return try HTTPResponse.response(method: request.method, urlResponse: urlResponse, data: responseBody)
     }
 
     private func invokeSession(_ urlRequest: URLRequest) async throws -> (Data, URLResponse) {
@@ -124,15 +113,11 @@ public struct URLSessionTransport: ClientTransport {
                     }
 
                     guard let response else {
-                        continuation.resume(
-                            with: .failure(URLSessionTransportError.noResponse(url: urlRequest.url))
-                        )
+                        continuation.resume(with: .failure(URLSessionTransportError.noResponse(url: urlRequest.url)))
                         return
                     }
 
-                    continuation.resume(
-                        with: .success((data ?? Data(), response))
-                    )
+                    continuation.resume(with: .success((data ?? Data(), response)))
                 }
                 .resume()
         }
@@ -153,46 +138,31 @@ internal enum URLSessionTransportError: Error {
 }
 
 extension HTTPResponse {
-    static func response(
-        method: HTTPRequest.Method,
-        urlResponse: URLResponse,
-        data: Data
-    ) throws -> (HTTPResponse, HTTPBody?) {
+    static func response(method: HTTPRequest.Method, urlResponse: URLResponse, data: Data) throws -> (
+        HTTPResponse, HTTPBody?
+    ) {
         guard let httpResponse = urlResponse as? HTTPURLResponse else {
             throw URLSessionTransportError.notHTTPResponse(urlResponse)
         }
         var headerFields = HTTPFields()
         for (headerName, headerValue) in httpResponse.allHeaderFields {
-            guard
-                let rawName = headerName as? String,
-                let name = HTTPField.Name(rawName),
+            guard let rawName = headerName as? String, let name = HTTPField.Name(rawName),
                 let value = headerValue as? String
-            else {
-                continue
-            }
+            else { continue }
             headerFields[name] = value
         }
         let body: HTTPBody?
         switch method {
-        case .head, .connect, .trace:
-            body = nil
-        default:
-            body = .init(data)
+        case .head, .connect, .trace: body = nil
+        default: body = .init(data)
         }
-        return (
-            HTTPResponse(
-                status: .init(code: httpResponse.statusCode),
-                headerFields: headerFields
-            ),
-            body
-        )
+        return (HTTPResponse(status: .init(code: httpResponse.statusCode), headerFields: headerFields), body)
     }
 }
 
 extension URLRequest {
     init(_ request: HTTPRequest, body: HTTPBody?, baseURL: URL) async throws {
-        guard
-            var baseUrlComponents = URLComponents(string: baseURL.absoluteString),
+        guard var baseUrlComponents = URLComponents(string: baseURL.absoluteString),
             let requestUrlComponents = URLComponents(string: request.path ?? "")
         else {
             throw URLSessionTransportError.invalidRequestURL(
@@ -206,11 +176,7 @@ extension URLRequest {
         baseUrlComponents.percentEncodedPath += path
         baseUrlComponents.percentEncodedQuery = requestUrlComponents.percentEncodedQuery
         guard let url = baseUrlComponents.url else {
-            throw URLSessionTransportError.invalidRequestURL(
-                path: path,
-                method: request.method,
-                baseURL: baseURL
-            )
+            throw URLSessionTransportError.invalidRequestURL(path: path, method: request.method, baseURL: baseURL)
         }
         self.init(url: url)
         self.httpMethod = request.method.rawValue
@@ -238,8 +204,7 @@ extension URLSessionTransportError: CustomStringConvertible {
                 "Invalid request URL from request path: \(path), method: \(method), relative to base URL: \(baseURL.absoluteString)"
         case .notHTTPResponse(let response):
             return "Received a non-HTTP response, of type: \(String(describing: type(of: response)))"
-        case .noResponse(let url):
-            return "Received a nil response for \(url?.absoluteString ?? "<nil URL>")"
+        case .noResponse(let url): return "Received a nil response for \(url?.absoluteString ?? "<nil URL>")"
         }
     }
 }

Tests/OpenAPIURLSessionTests/Locking.swift

@@ -20,8 +20,7 @@ import Foundation
 /// performed manually using locks.
 ///
 /// Note: Use the `package` access modifier once min Swift version is increased.
-@_spi(Locking)
-public final class LockedValueBox<Value: Sendable>: @unchecked Sendable {
+@_spi(Locking) public final class LockedValueBox<Value: Sendable>: @unchecked Sendable {
     private let lock: NSLock = {
         let lock = NSLock()
         lock.name = "com.apple.swift-openapi-urlsession.lock.LockedValueBox"
@@ -31,9 +30,7 @@ public final class LockedValueBox<Value: Sendable>: @unchecked Sendable {
     /// Initializes a new `LockedValueBox` instance with the provided initial value.
     ///
     /// - Parameter value: The initial value to store in the `LockedValueBox`.
-    public init(_ value: Value) {
-        self.value = value
-    }
+    public init(_ value: Value) { self.value = value }
     /// Perform an operation on the value in a synchronized manner.
     ///
     /// - Parameter work: A closure that takes an inout reference to the wrapped value and returns a result.
@@ -42,9 +39,7 @@ public final class LockedValueBox<Value: Sendable>: @unchecked Sendable {
     /// - Returns: The result of the closure passed to `work`.
     public func withValue<R>(_ work: (inout Value) throws -> R) rethrows -> R {
         lock.lock()
-        defer {
-            lock.unlock()
-        }
+        defer { lock.unlock() }
         return try work(&value)
     }
 }

Tests/OpenAPIURLSessionTests/URLSessionTransportTests.swift

@@ -37,16 +37,10 @@ class URLSessionTransportTests: XCTestCase {
             scheme: nil,
             authority: nil,
             path: "/hello%20world/Maria?greeting=Howdy",
-            headerFields: [
-                .init("x-mumble2")!: "mumble"
-            ]
+            headerFields: [.init("x-mumble2")!: "mumble"]
         )
         let body: HTTPBody = "👋"
-        let urlRequest = try await URLRequest(
-            request,
-            body: body,
-            baseURL: URL(string: "http://example.com/api")!
-        )
+        let urlRequest = try await URLRequest(request, body: body, baseURL: URL(string: "http://example.com/api")!)
         XCTAssertEqual(urlRequest.url, URL(string: "http://example.com/api/hello%20world/Maria?greeting=Howdy"))
         XCTAssertEqual(urlRequest.httpMethod, "POST")
         XCTAssertEqual(urlRequest.allHTTPHeaderFields?.count, 1)
@@ -91,9 +85,7 @@ class URLSessionTransportTests: XCTestCase {
             scheme: nil,
             authority: nil,
             path: "/hello%20world/Maria?greeting=Howdy",
-            headerFields: [
-                .init("x-mumble1")!: "mumble"
-            ]
+            headerFields: [.init("x-mumble1")!: "mumble"]
         )
         let requestBody: HTTPBody = "👋"
         let (response, maybeResponseBody) = try await transport.send(
@@ -128,18 +120,13 @@ class MockURLProtocol: URLProtocol {
     override func startLoading() {
         Self.recordedHTTPRequests.withValue { $0.append(self.request) }
         guard let url = self.request.url else { return }
-        guard let response = Self.mockHTTPResponses.withValue({ $0[url] }) else {
-            return
-        }
+        guard let response = Self.mockHTTPResponses.withValue({ $0[url] }) else { return }
         switch response {
         case .success(let mockResponse):
             client?.urlProtocol(self, didReceive: mockResponse.response, cacheStoragePolicy: .notAllowed)
-            if let data = mockResponse.body {
-                client?.urlProtocol(self, didLoad: data)
-            }
+            if let data = mockResponse.body { client?.urlProtocol(self, didLoad: data) }
             client?.urlProtocolDidFinishLoading(self)
-        case let .failure(error):
-            client?.urlProtocol(self, didFailWithError: error)
+        case let .failure(error): client?.urlProtocol(self, didFailWithError: error)
         }
     }