Skip to content

Commit b853d2d

Browse files
Revert "Disable failing container tests (pulumi#264)" (pulumi#265)
1 parent e09625a commit b853d2d

File tree

4 files changed

+38
-53
lines changed

4 files changed

+38
-53
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ensure:
88
only_build:
99

1010
only_test:
11-
go test ./misc/test/... --timeout 2h -v -count=1 -short -parallel 8
11+
go test ./misc/test/... --timeout 2h -v -count=1 -short -parallel 20
1212

1313
# The travis_* targets are entrypoints for CI.
1414
.PHONY: travis_cron travis_push travis_pull_request travis_api

aws-ts-apigateway/index.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as aws from "@pulumi/aws";
2+
import * as awsx from "@pulumi/awsx";
23

34
// Create a mapping from 'route' to a count
45
let counterTable = new aws.dynamodb.Table("counterTable", {
@@ -12,14 +13,14 @@ let counterTable = new aws.dynamodb.Table("counterTable", {
1213
});
1314

1415
// Create an API endpoint
15-
let endpoint = new aws.apigateway.x.API("hello-world", {
16+
let endpoint = new awsx.apigateway.API("hello-world", {
1617
routes: [{
1718
path: "/{route+}",
1819
method: "GET",
1920
eventHandler: async (event) => {
2021
let route = event.pathParameters["route"];
2122
console.log(`Getting count for '${route}'`);
22-
23+
2324
const client = new aws.sdk.DynamoDB.DocumentClient();
2425

2526
// get previous value and increment

aws-ts-apigateway/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"version": "0.1.0",
44
"dependencies": {
55
"@pulumi/aws": "latest",
6+
"@pulumi/awsx": "latest",
67
"@pulumi/pulumi": "latest"
78
}
89
}

misc/test/examples_test.go

+33-50
Original file line numberDiff line numberDiff line change
@@ -45,24 +45,19 @@ func TestExamples(t *testing.T) {
4545
}
4646

4747
shortTests := []integration.ProgramTestOptions{
48-
// Test disabled due to flakiness
49-
// https://github.com/pulumi/examples/issues/263
50-
/*
51-
base.With(integration.ProgramTestOptions{
52-
Dir: path.Join(cwd, "..", "..", "aws-js-containers"),
53-
Config: map[string]string{
54-
"aws:region": awsRegion,
55-
},
56-
ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {
57-
maxWait := 10 * time.Minute
58-
endpoint := stack.Outputs["frontendURL"].(string)
59-
assertHTTPResultWithRetry(t, endpoint, maxWait, func(body string) bool {
60-
return assert.Contains(t, body, "Hello, Pulumi!")
61-
})
62-
},
63-
}),
64-
*/
65-
48+
base.With(integration.ProgramTestOptions{
49+
Dir: path.Join(cwd, "..", "..", "aws-js-containers"),
50+
Config: map[string]string{
51+
"aws:region": awsRegion,
52+
},
53+
ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {
54+
maxWait := 10 * time.Minute
55+
endpoint := stack.Outputs["frontendURL"].(string)
56+
assertHTTPResultWithRetry(t, endpoint, maxWait, func(body string) bool {
57+
return assert.Contains(t, body, "Hello, Pulumi!")
58+
})
59+
},
60+
}),
6661
base.With(integration.ProgramTestOptions{
6762
Dir: path.Join(cwd, "..", "..", "aws-js-s3-folder"),
6863
Config: map[string]string{
@@ -137,25 +132,19 @@ func TestExamples(t *testing.T) {
137132
"create-role:unprivilegedUsername": "unpriv",
138133
},
139134
}),
140-
141-
// Test disabled due to flakiness
142-
// https://github.com/pulumi/examples/issues/263
143-
/*
144-
base.With(integration.ProgramTestOptions{
145-
Dir: path.Join(cwd, "..", "..", "aws-ts-containers"),
146-
Config: map[string]string{
147-
"aws:region": awsRegion,
148-
},
149-
ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {
150-
maxWait := 10 * time.Minute
151-
endpoint := stack.Outputs["frontendURL"].(string)
152-
assertHTTPResultWithRetry(t, endpoint, maxWait, func(body string) bool {
153-
return assert.Contains(t, body, "Hello, Pulumi!")
154-
})
155-
},
156-
}),
157-
*/
158-
135+
base.With(integration.ProgramTestOptions{
136+
Dir: path.Join(cwd, "..", "..", "aws-ts-containers"),
137+
Config: map[string]string{
138+
"aws:region": awsRegion,
139+
},
140+
ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {
141+
maxWait := 10 * time.Minute
142+
endpoint := stack.Outputs["frontendURL"].(string)
143+
assertHTTPResultWithRetry(t, endpoint, maxWait, func(body string) bool {
144+
return assert.Contains(t, body, "Hello, Pulumi!")
145+
})
146+
},
147+
}),
159148
base.With(integration.ProgramTestOptions{
160149
Dir: path.Join(cwd, "..", "..", "aws-ts-pulumi-webhooks"),
161150
Config: map[string]string{
@@ -280,19 +269,13 @@ func TestExamples(t *testing.T) {
280269
})
281270
},
282271
}),
283-
284-
// Test disabled due to flakiness
285-
// https://github.com/pulumi/examples/issues/263
286-
/*
287-
base.With(integration.ProgramTestOptions{
288-
Dir: path.Join(cwd, "..", "..", "cloud-js-containers"),
289-
Config: map[string]string{
290-
"aws:region": awsRegion,
291-
"cloud-aws:useFargate": "true",
292-
},
293-
}),
294-
*/
295-
272+
base.With(integration.ProgramTestOptions{
273+
Dir: path.Join(cwd, "..", "..", "cloud-js-containers"),
274+
Config: map[string]string{
275+
"aws:region": awsRegion,
276+
"cloud-aws:useFargate": "true",
277+
},
278+
}),
296279
base.With(integration.ProgramTestOptions{
297280
Dir: path.Join(cwd, "..", "..", "cloud-js-httpserver"),
298281
Config: map[string]string{

0 commit comments

Comments
 (0)