Merge pull request #4 from aptoma/fix-error-output

Fix error output

Author: Michael

index.js

@@ -122,11 +122,11 @@ function formatError(req, h) {
 		if (response.output.statusCode === 500) {
 			req.log('error', response.data instanceof Buffer ? response.data.toString() : response.data);
 		}
+	}
 
-		if (response.data.isJoi && response.data.details && typeof response.data.details.map === 'function') {
-			const message = response.data.details.map(getJoiErrorMessage).join(', ');
-			errorObject.details = message;
-		}
+	if (response.isJoi && response.details && typeof response.details.map === 'function') {
+		const message = response.details.map(getJoiErrorMessage).join(', ');
+		errorObject.details = message;
 	}
 
 	return h.response({

test/index.test.js

@@ -1,12 +1,42 @@
 'use strict';
 
 const Hapi = require('hapi');
+const Joi = require('joi');
 const assert = require('chai').assert;
 const jsonapi = require('../');
 const plugin = jsonapi.plugin;
 
 describe('JSON API Plugin', () => {
 
+	describe('Error formatting', () => {
+		it('should format joi errors to more human readable output', async () => {
+			const server = new Hapi.Server({debug: {request: '*'}});
+			await server.register({plugin});
+			server.route({
+				method: 'POST',
+				path: '/test',
+				config: {
+					validate: {
+						failAction: (req, h, err) => err,
+						payload: {
+							fo: Joi.object({
+								bar: Joi.object({
+									banana: Joi.number().required()
+								}).required()
+							}).required()
+						}
+					},
+					handler(req, h) {
+						return h.response().code(204);
+					}
+				}
+			});
+
+			const res = await server.inject({method: 'POST', url: '/test', payload: {fo: {}}});
+			assert.equal(res.result.errors[0].details, 'Validation error: "bar" is required (fo,bar)');
+		});
+	});
+
 	describe('Decorated reply functions', () => {
 		let server;