Loggable.logger returns a new logger each time, but is used as an object property

[bjkeller]

There are tests in test_loggable.py that are failing.

The root cause seems to be that Loggable.logger

pydent/pydent/utils/loggable/__init__.py

Line 155 in 63dbf01

def logger(self):

returns a new logger each time with the level set to ERROR, but it is used in other Loggable methods as if it were a property of the Loggable object.
For instance, in Loggable.set_level where each subsequent call to self.logger is a new logger.
With

pydent/pydent/utils/loggable/__init__.py

Line 201 in 63dbf01

self.logger.setLevel(level)

followed immediately by

pydent/pydent/utils/loggable/__init__.py

Line 202 in 63dbf01

for h in self.logger.handlers:

which means none of this is doing what it looks like it is doing.

I think Loggable either needs to be a factory, in which case it should store the parameters for loggers and handlers.
Or, it should manage a single logger object with its handlers.