Skip to content

Commit d32b19f

Browse files
Merge pull request #1537 from arcaneframework/dev/gg-remove-variable-expression
Remove compilation of VariableExpression and associated classes
2 parents 41a6681 + 6722a7a commit d32b19f

File tree

7 files changed

+31
-60
lines changed

7 files changed

+31
-60
lines changed

arcane/src/arcane/core/IVariable.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class IDataReader;
3333
class IDataWriter;
3434
class VariableMng;
3535
class Module;
36-
class Expression;
3736
class IVariableComputeFunction;
3837
class IObservable;
3938
class IDataOperation;
@@ -262,15 +261,6 @@ class ARCANE_CORE_EXPORT IVariable
262261
//! Nombre de références sur cette variable
263262
virtual Integer nbReference() const =0;
264263

265-
266-
public:
267-
268-
//%% ARCANE_BENCH_SUPPRESS_BEGIN
269-
virtual Expression expression() =0;
270-
271-
public:
272-
//%% ARCANE_BENCH_SUPPRESS_END
273-
274264
public:
275265

276266
ARCANE_DEPRECATED_REASON("Y2021: This method is a noop")

arcane/src/arcane/core/Variable.cc

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@
3131
#include "arcane/utils/MemoryView.h"
3232

3333
#include "arcane/core/ItemGroupObserver.h"
34-
#include "arcane/core/expr/Expression.h"
35-
#include "arcane/core/VariableExpressionImpl.h"
3634
#include "arcane/core/Variable.h"
3735
#include "arcane/core/VarRefEnumerator.h"
3836
#include "arcane/core/IVariableAccessor.h"
@@ -522,15 +520,6 @@ dataType() const
522520
return m_p->m_infos.dataType();
523521
}
524522

525-
/*---------------------------------------------------------------------------*/
526-
/*---------------------------------------------------------------------------*/
527-
528-
Expression Variable::
529-
expression()
530-
{
531-
return Expression(new VariableExpressionImpl(this));
532-
}
533-
534523
/*---------------------------------------------------------------------------*/
535524
/*---------------------------------------------------------------------------*/
536525
/*!

arcane/src/arcane/core/Variable.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,6 @@ class ARCANE_CORE_EXPORT Variable
106106
int property() const override;
107107
void notifyReferencePropertyChanged() override;
108108

109-
public:
110-
111-
Expression expression() override;
112-
113109
public:
114110

115111
//! Positionne l'état d'utilisation de la variable

arcane/src/arcane/core/VariableExpressionImpl.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
// -*- tab-width: 2; indent-tabs-mode: nil; coding: utf-8-with-signature -*-
22
//-----------------------------------------------------------------------------
3-
// Copyright 2000-2022 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
3+
// Copyright 2000-2024 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
44
// See the top-level COPYRIGHT file for details.
55
// SPDX-License-Identifier: Apache-2.0
66
//-----------------------------------------------------------------------------
7+
#error "VariableExpression are no longer available. Do not include this file"
78
/*---------------------------------------------------------------------------*/
8-
/* VariableExpressionImpl.h (C) 2000-2004 */
9+
/* VariableExpressionImpl.h (C) 2000-2024 */
910
/* */
1011
/* Expression traitant une variable. */
1112
/*---------------------------------------------------------------------------*/

arcane/src/arcane/core/srcs.cmake

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
set(CURRENT_SRC_PATH ${Arcane_SOURCE_DIR}/src)
1+
set(CURRENT_SRC_PATH ${Arcane_SOURCE_DIR}/src)
22

33
set(ARCANE_MATERIALS_SOURCES
44
materials/CellToAllEnvCellConverter.h
@@ -621,8 +621,8 @@ set(ARCANE_ORIGINAL_SOURCES
621621
VariableDependInfo.h
622622
VariableDiff.h
623623
VariableDiff.cc
624-
VariableExpressionImpl.cc
625-
VariableExpressionImpl.h
624+
#VariableExpressionImpl.cc
625+
#VariableExpressionImpl.h
626626
VariableFactory.cc
627627
VariableFactory.h
628628
VariableFactoryRegisterer.cc
@@ -690,31 +690,31 @@ set(ARCANE_ORIGINAL_SOURCES
690690
datatype/VariantBase.cc
691691
datatype/VariantBase.h
692692

693-
expr/IExpressionImpl.h
694-
expr/Expression.h
695-
expr/ArrayExpressionImpl.cc
696-
expr/ArrayExpressionImpl.h
697-
expr/BadExpressionException.cc
698-
expr/BadExpressionException.h
699-
expr/BadOperandException.cc
700-
expr/BadOperandException.h
701-
expr/BadOperationException.cc
702-
expr/BadOperationException.h
703-
expr/Expression.cc
704-
expr/ExpressionResult.cc
705-
expr/ExpressionResult.h
706-
expr/ExpressionImpl.cc
707-
expr/ExpressionImpl.h
708-
expr/UnaryExpressionImpl.cc
709-
expr/UnaryExpressionImpl.h
710-
expr/LitteralExpressionImpl.cc
711-
expr/LitteralExpressionImpl.h
712-
expr/BinaryExpressionImpl.cc
713-
expr/BinaryExpressionImpl.h
714-
expr/WhereExpressionImpl.cc
715-
expr/WhereExpressionImpl.h
716-
expr/OperatorMng.cc
717-
expr/OperatorMng.h
693+
# expr/IExpressionImpl.h
694+
# expr/Expression.h
695+
# expr/ArrayExpressionImpl.cc
696+
# expr/ArrayExpressionImpl.h
697+
# expr/BadExpressionException.cc
698+
# expr/BadExpressionException.h
699+
# expr/BadOperandException.cc
700+
# expr/BadOperandException.h
701+
# expr/BadOperationException.cc
702+
# expr/BadOperationException.h
703+
# expr/Expression.cc
704+
# expr/ExpressionResult.cc
705+
# expr/ExpressionResult.h
706+
# expr/ExpressionImpl.cc
707+
# expr/ExpressionImpl.h
708+
# expr/UnaryExpressionImpl.cc
709+
# expr/UnaryExpressionImpl.h
710+
# expr/LitteralExpressionImpl.cc
711+
# expr/LitteralExpressionImpl.h
712+
# expr/BinaryExpressionImpl.cc
713+
# expr/BinaryExpressionImpl.h
714+
# expr/WhereExpressionImpl.cc
715+
# expr/WhereExpressionImpl.h
716+
# expr/OperatorMng.cc
717+
# expr/OperatorMng.h
718718

719719
anyitem/AnyItem.h
720720
anyitem/AnyItemGlobal.h

arcane/tools/wrapper/core/ArcaneSwigCore.i

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,6 @@ class IEntryPoint
475475
%include arcane/core/IApplication.h
476476
%include arcane/core/IDirectory.h
477477
%include arcane/core/ItemGroupImpl.h
478-
%include arcane/core/expr/IExpressionImpl.h
479478
%include arcane/core/SharedReference.h
480479
%include arcane/utils/IObserver.h
481480
%include arcane/utils/Observer.h
@@ -556,7 +555,6 @@ ARCANE_STD_EXHANDLER
556555

557556
%include arcane/core/IVariableMng.h
558557
%include arcane/core/IVariable.h
559-
%include arcane/core/expr/Expression.h
560558
%include arcane/core/IArcaneMain.h
561559
%include arcane/core/ITimeLoopMng.h
562560
%include arcane/core/datatype/ScalarVariant.h

arcane/tools/wrapper/core/ArcaneSwigCoreInclude.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
#include "arcane/utils/ArrayShape.h"
2222
#include "arcane/utils/MemoryView.h"
2323

24-
#include "arcane/expr/Expression.h"
25-
#include "arcane/expr/ArrayExpressionImpl.h"
26-
2724
#include "arcane/core/IApplication.h"
2825
#include "arcane/core/ISubDomain.h"
2926
#include "arcane/core/ISession.h"

0 commit comments

Comments
 (0)