chore: investigate migrating to biome

Author: brianleroux

.gitignore

@@ -9,3 +9,4 @@ scratch/
 test/mock/*/src/*/*/vendor/
 test/mock/tmp/
 yarn.lock
+.kiro

biome.json

@@ -0,0 +1,56 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "ignoreUnknown": false,
+    "ignore": [
+      ".nyc_output/",
+      "arc-proxy-*",
+      "coverage/",
+      "dist.js",
+      "scratch/",
+      "src/http/get-index",
+      "types/",
+      "node_modules/",
+      "test/mock/*/src/*/*/vendor/",
+      "test/mock/tmp/"
+    ]
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineWidth": 120
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "style": {
+        "noVar": "error",
+        "useConst": "error",
+        "noParameterAssign": "off",
+        "useDefaultParameterLast": "off"
+      },
+      "complexity": {
+        "noForEach": "off"
+      },
+      "performance": {
+        "noDelete": "off"
+      },
+      "suspicious": {
+        "noExplicitAny": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "semicolons": "asNeeded",
+      "quoteStyle": "single"
+    }
+  }
+}

eslint.config.js

@@ -3,14 +3,6 @@ const arc = require('@architect/eslint-config')
 module.exports = [
   ...arc,
   {
-    ignores: [
-      '.nyc_output/',
-      'arc-proxy-*',
-      'coverage/',
-      'dist.js',
-      'scratch/',
-      'src/http/get-index',
-      'types/',
-    ],
+    ignores: ['.nyc_output/', 'arc-proxy-*', 'coverage/', 'dist.js', 'scratch/', 'src/http/get-index', 'types/'],
   },
 ]

package.json

@@ -12,7 +12,8 @@
   "types": "types/index.d.ts",
   "scripts": {
     "test:one": "cross-env tape 'test/unit/src/http/csrf/*-test.js' | tap-arc",
-    "lint": "eslint --fix .",
+    "lint": "biome check --write .",
+    "lint:fmt": "biome format --write .",
     "test": "npm run lint && npm run test:integration && npm run coverage && npm run test:types",
     "test:nolint": "npm run test:integration && npm run coverage && npm run test:types",
     "test:unit": "cross-env tape 'test/unit/**/*-test.js' | tap-arc",
@@ -50,6 +51,7 @@
     "@aws-lite/dynamodb-types": "^0.3.11",
     "@aws-lite/sns-types": "^0.0.10",
     "@aws-lite/sqs-types": "^0.2.6",
+    "@biomejs/biome": "^1.9.4",
     "@types/aws-lambda": "^8.10.147",
     "@types/node": "^24.5.2",
     "cross-env": "^10.0.0",
@@ -62,10 +64,7 @@
     "tiny-json-http": "^7.5.1",
     "tsd": "^0.33.0"
   },
-  "files": [
-    "types/*",
-    "src/*"
-  ],
+  "files": ["types/*", "src/*"],
   "keywords": [
     "aws",
     "lambda",

src/discovery/index.js

@@ -1,14 +1,13 @@
-let { getAwsClient, useAWS } = require('../lib')
+const { getAwsClient, useAWS } = require('../lib')
 
 /**
  * @param {string} type - events, queues, or tables
  * @returns {object} {name: value}
  */
-module.exports = function lookup (callback) {
-
+module.exports = function lookup(callback) {
   let { ARC_APP_NAME: app, ARC_ENV: env, ARC_SANDBOX, ARC_STACK_NAME: stack } = process.env
 
-  let local = !useAWS()
+  const local = !useAWS()
 
   if (!local && !app && !stack) {
     return callback(ReferenceError('ARC_APP_NAME and ARC_STACK_NAME env vars not found'))
@@ -18,12 +17,12 @@ module.exports = function lookup (callback) {
     app = 'arc-app'
   }
 
-  let plugins = [ import('@aws-lite/ssm') ]
-  let config = { plugins }
+  const plugins = [import('@aws-lite/ssm')]
+  const config = { plugins }
   if (local) {
     let port = 2222
     if (ARC_SANDBOX) {
-      let { ports } = JSON.parse(ARC_SANDBOX)
+      const { ports } = JSON.parse(ARC_SANDBOX)
       if (!ports._arc) {
         return callback(ReferenceError('Sandbox internal port not found'))
       }
@@ -35,19 +34,22 @@ module.exports = function lookup (callback) {
   getAwsClient(config, (err, client) => {
     if (err) callback(err)
     else {
-      let Path = `/${stack || toLogicalID(`${app}-${env}`)}`
-      client.ssm.GetParametersByPath({ Path, Recursive: true, paginate: true })
-        .then(result => {
-          let services = result.Parameters.reduce((a, b) => {
-            let hierarchy = b.Name.split('/')
+      const Path = `/${stack || toLogicalID(`${app}-${env}`)}`
+      client.ssm
+        .GetParametersByPath({ Path, Recursive: true, paginate: true })
+        .then((result) => {
+          const services = result.Parameters.reduce((a, b) => {
+            const hierarchy = b.Name.split('/')
             hierarchy.shift() // leading slash
             hierarchy.shift() // stack name
-            let type = hierarchy.shift() // i.e. tables, events, queues, plugins
+            const type = hierarchy.shift() // i.e. tables, events, queues, plugins
             if (!a[type]) a[type] = {}
             let parent = a[type]
-            let child, lastChild, lastParent
-            /* eslint-disable-next-line */
-            while (child = hierarchy.shift()) {
+            let child
+            let lastChild
+            let lastParent
+            // biome-ignore lint/suspicious/noAssignInExpressions: we know what we are doing here
+            while ((child = hierarchy.shift())) {
               if (!parent[child]) parent[child] = {}
               lastParent = parent
               parent = parent[child]
@@ -58,22 +60,19 @@ module.exports = function lookup (callback) {
           }, {})
           callback(null, services)
         })
-        .catch(err => {
-          if (err && local &&
-              err.message.includes('Inaccessible host') &&
-              err.message.includes('localhost')) {
-            let msg = 'Sandbox internal services are unavailable, please ensure Sandbox is running'
+        .catch((err) => {
+          if (err && local && err.message.includes('Inaccessible host') && err.message.includes('localhost')) {
+            const msg = 'Sandbox internal services are unavailable, please ensure Sandbox is running'
             callback(ReferenceError(msg))
-          }
-          else {
+          } else {
             callback(err)
           }
         })
     }
   })
 }
 
-function toLogicalID (str) {
+function toLogicalID(str) {
   str = str.replace(/([A-Z])/g, ' $1')
   if (str.length === 1) {
     return str.toUpperCase()

src/events/index.js

@@ -1,8 +1,8 @@
-let pubFactory = require('./publish')
-let subFactory = require('./subscribe')
+const pubFactory = require('./publish')
+const subFactory = require('./subscribe')
 
-module.exports = function eventsAndQueuesFactory (arc, type) {
-  let publish = pubFactory(arc, type)
-  let subscribe = subFactory(type)
+module.exports = function eventsAndQueuesFactory(arc, type) {
+  const publish = pubFactory(arc, type)
+  const subscribe = subFactory(type)
   return { publish, subscribe }
 }