Reduce likelihood of false negative tests on slow file writes in Win + Mac CI matrix

Author: ryanblock

test/integration/lambda-termination-test.js

@@ -1,6 +1,7 @@
 let test = require('tape')
 let { existsSync, mkdirSync, readdirSync, rmSync } = require('fs')
 let { join } = require('path')
+let chokidar = require('chokidar')
 let sandbox = require('../../src')
 let mock = join(process.cwd(), 'test', 'mock')
 let { run, startup, shutdown } = require('../utils')
@@ -9,7 +10,7 @@ let fileThatShouldNotBeWritten = join(tmp, 'do-not-write-me')
 let payload = { path: fileThatShouldNotBeWritten }
 let eventsPort = 4444
 let timeout = 1250
-let arc
+let arc, watcher
 
 // Because these tests are firing Arc Functions events, that module needs a `ARC_EVENTS_PORT` env var to run locally
 // That said, to prevent side-effects, destroy that env var immediately after use
@@ -26,12 +27,12 @@ function reset (t) {
   delete process.env.ARC_ENV
   delete process.env.ARC_SANDBOX
 }
-function check (t) {
+function check (t, altTimeout) {
   setTimeout(() => {
     console.log('Files in tmp:', readdirSync(tmp))
     t.notOk(existsSync(fileThatShouldNotBeWritten), 'File not created as event timed out and process was terminated appropriately')
     reset(t)
-  }, timeout)
+  }, altTimeout || timeout)
 }
 
 test('Set up env', t => {
@@ -59,17 +60,32 @@ function runTests (runType, t) {
     t.plan(3)
     setup(t)
     let fine = join(tmp, 'fine-write-me')
+    let timer
+
+    watcher = chokidar.watch(tmp)
+    watcher.on('add', function (added) {
+      if (added === fine) {
+        clearTimeout(timer)
+        watcher.close().then(() => {
+          console.log('Files in tmp:', readdirSync(tmp))
+          t.pass('File successfully created by event as event did not time out')
+          reset(t)
+        })
+      }
+    })
+
     arc.events.publish({
       name: 'event-does-not-timeout',
       payload: { path: fine }
     },
     function done (err) {
       if (err) t.fail(err)
-      else setTimeout(() => {
-        console.log('Files in tmp:', readdirSync(tmp))
-        t.ok(existsSync(fine), 'File successfully created by event as event did not time out')
-        reset(t)
-      }, 1000)
+      else {
+        let ohno = 10000
+        timer = setTimeout(() => {
+          t.fail(`Did not write file in ${ohno}ms, sigh`)
+        }, ohno)
+      }
     })
   })
 
@@ -148,7 +164,7 @@ function runTests (runType, t) {
     },
     function done (err) {
       if (err) t.fail(err)
-      else check(t)
+      else check(t, 600)
     })
   })
 

test/mock/lambda-termination/src/events/event-does-not-timeout/config.arc

@@ -1,2 +1,2 @@
 @aws
-timeout 1
+timeout 5

test/mock/lambda-termination/src/events/event-timeout-async-child/index.js

@@ -4,7 +4,6 @@ let { spawnSync } = require('child_process')
 exports.handler = async (event) => {
   event = JSON.parse(event.Records[0].Sns.Message)
   let pathToFile = event.path
-
   let timeout = '1.25' // this event is configured to time out after 1s (see config.arc), so we'll sleep longer
   console.log(`event-timeout-async-child will write to ${pathToFile} in ${timeout}s...`)
   // this should sleep but be terminated before getting to echo as timeout is set to 1 sec in config.arc

test/mock/lambda-termination/src/events/event-timeout-async-settimeout/index.js

@@ -4,7 +4,7 @@ let { join } = require('path')
 exports.handler = async (event) => {
   event = JSON.parse(event.Records[0].Sns.Message)
   let pathToFile = event.path
-  let timeout = 1250 // this event is configured to time out after 1s (see config.arc), so lets setTimeout longer
+  let timeout = 1250 // this event is configured to time out after 1s (see config.arc), so let's setTimeout longer
   console.log(`event-timeout-async-settimeout will write to ${pathToFile} in ${timeout}ms...`)
   setTimeout(() => {
     // this should never execute as timeout is set to 1 sec in config.arc

test/mock/lambda-termination/src/events/event-timeout-async/index.js

@@ -4,7 +4,6 @@ let { join } = require('path')
 exports.handler = async (event) => {
   event = JSON.parse(event.Records[0].Sns.Message)
   let pathToFile = event.path
-
   let timeout = 1250 // this event is configured to time out after 1s (see config.arc), so we'll setTimeout longer
   console.log(`event-timeout-async will write to ${pathToFile} in ${timeout}ms...`)
   await new Promise(resolve => setTimeout(resolve, timeout))

test/mock/lambda-termination/src/events/event-timeout-sync-child/index.js

@@ -4,7 +4,6 @@ let { spawnSync } = require('child_process')
 exports.handler = (event, context, callback) => {
   event = JSON.parse(event.Records[0].Sns.Message)
   let pathToFile = event.path
-
   let timeout = '1.25' // this event is configured to time out after 1s (see config.arc), so we'll sleep longer
   console.log(`event-timeout-sync-child will write to ${pathToFile} in ${timeout}s...`)
   // this should sleep but be terminated before getting to echo as timeout is set to 1 sec in config.arc

test/mock/lambda-termination/src/events/event-timeout-sync/index.js

@@ -4,8 +4,7 @@ let { join } = require('path')
 exports.handler = (event, context, callback) => {
   event = JSON.parse(event.Records[0].Sns.Message)
   let pathToFile = event.path
-
-  let timeout = 1250 // this event is configured to time out after 1s (see config.arc), so lets setTimeout longer
+  let timeout = 1250 // this event is configured to time out after 1s (see config.arc), so let's setTimeout longer
   console.log(`event-timeout-sync will write to ${pathToFile} in ${timeout}ms...`)
   setTimeout(() => {
     // this should never execute as timeout is set to 1 sec in config.arc