Promote livereload to being enabled by default

Author: ryanblock

changelog.md

@@ -2,6 +2,14 @@
 
 ---
 
+## [5.5.0] 2023-02-01
+
+### Added
+
+- Promotes livereload feature to being enabled by default
+
+---
+
 ## [5.4.2] 2023-01-18
 
 ### Changed

src/arc/_livereload/index.js

@@ -2,7 +2,9 @@ let _ws = require('ws')
 
 module.exports = function livereload (_arcServices, params) {
   let { inventory, restart, update } = params
-  let enabled = inventory.inv._project.preferences?.sandbox?.livereload
+
+  let livereloadSetting = inventory.inv._project.preferences?.sandbox?.livereload
+  let enabled = typeof livereloadSetting === 'undefined' ? true : livereloadSetting
   if (!enabled) return
 
   let ws = new _ws.WebSocketServer({ server: _arcServices })

src/http/invoke-http/index.js

@@ -46,7 +46,8 @@ module.exports = function invokeHTTP (params) {
         res.end(body)
       }
       else {
-        let livereload = inventory.inv._project.preferences?.sandbox?.livereload
+        let livereloadSetting = inventory.inv._project.preferences?.sandbox?.livereload
+        let livereload = typeof livereloadSetting === 'undefined' ? true : livereloadSetting
         let opts = { livereload, ports }
 
         // Totally separate out response validation paths to ensure type checks don't inadvertently blow everything up

src/sandbox/print-status.js

@@ -26,15 +26,16 @@ module.exports = function prettyPrint (params, start, callback) {
 
     if (http) {
       let folder = `${inventory.inv.static.folder}${sep}`
-      let liveReload = inventory.inv._project.preferences?.sandbox?.livereload
+      let livereloadSetting = inventory.inv._project.preferences?.sandbox?.livereload
+      let livereload = typeof livereloadSetting === 'undefined' ? true : livereloadSetting
       let msgs = {
         rest: 'REST API mode / Lambda proxy',
         http: 'HTTP API mode / Lambda proxy v2.0 format',
         httpv2: 'HTTP API mode / Lambda proxy v2.0 format',
         httpv1: 'HTTP API mode / Lambda proxy v1.0 format',
       }
       let msg = msgs[apiType]
-      if (liveReload) msg += ' / live reload'
+      if (livereload) msg += ' / live reload'
       let andWs = ws ? '& @ws ' : ''
       update.done(`@http (${msg}) ${andWs}routes`)
       http.forEach(({ method, path, src, arcStaticAssetProxy }) => {

test/unit/src/http/invoke-http/index-req-test.js

@@ -26,11 +26,7 @@ let url = i => `http://localhost:6666${i ? i : ''}`
 let str = i => JSON.stringify(i)
 let match = (copy, item) => `${copy} matches: ${str(item)}`
 let response = {
-  getHeader: sinon.fake(h => {
-    let header = h && h.toLowerCase()
-    if (header === 'cache-control') return undefined
-    if (header === 'content-type') return 'application/json; charset=utf-8'
-  }),
+  getHeaders: () => ({ 'content-type': 'application/json; charset=utf-8' }),
   setHeader: sinon.fake.returns(),
   end: sinon.fake.returns()
 }

test/unit/src/http/invoke-http/index-res-test.js

@@ -52,11 +52,7 @@ function getInvoker (params, response, callback) {
   }
   // Mocked res object
   let output = {
-    getHeader: sinon.fake(h => {
-      let header = h && h.toLowerCase()
-      if (header === 'cache-control') return undefined
-      if (header === 'content-type') return 'application/json; charset=utf-8'
-    }),
+    getHeaders: () => ({ 'content-type': 'application/json; charset=utf-8' }),
     statusCode: sinon.fake.returns(),
     setHeader: sinon.fake.returns(),
     end: sinon.fake.returns()