Subject edit

Author: blacksmith-welder

staff_features/shared/step_definitions.rb

@@ -80,7 +80,6 @@
 
 When 'the user clicks on {string} in the dropdown menu' do |string|
   dropdown_menu = all('.dropdown-menu').first
-
   dropdown_menus = all('.dropdown-menu')
 
   within dropdown_menus.first do |dropdown_menu|
@@ -247,10 +246,12 @@
 When 'the user changes the {string} field to {string}' do |field, value|
   element = find_field(field, match: :first)
 
-  if element.tag_name == 'select'
-    element.select value
+  field = find_field(field, match: :first)
+
+  if field.tag_name == 'select'
+    field.select value.strip
   else
-    element.fill_in with: value
+    field.fill_in with: value
   end
 end
 
@@ -272,6 +273,12 @@
   expect(find('.alert.alert-success.with-hide-alert').text).to match(/^#{string}.*updated$/i)
 end
 
+Then('the {string} saved message is displayed') do |string|
+  wait_for_ajax if current_url.include? 'resources'
+
+  expect(find('.alert.alert-success.with-hide-alert').text).to match(/^#{string}.*saved$/i)
+end
+
 Then('the {string} deleted message is displayed') do |string|
   expect(find('.alert.alert-success.with-hide-alert').text).to match(/^#{string}.*deleted$/i)
 end
@@ -384,3 +391,13 @@
 
   click_on 'Save'
 end
+
+When 'the user clears {string} in the {string} form' do |label, form_title|
+  section_title = find('h3', text: form_title)
+  section = section_title.ancestor('section')
+  expect(section[:id]).to_not eq nil
+
+  within section do
+    select '', from: label
+  end
+end

staff_features/subjects/step_definitions/subject_edit.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+Given 'the Subject appears in the search results list' do
+  visit "#{STAFF_URL}/subjects"
+
+  fill_in 'filter-text', with: "subject_term_#{@uuid}"
+
+  within '.search-filter' do
+    find('button').click
+  end
+
+  search_result_rows = all('#tabledSearchResults tbody tr')
+  expect(search_result_rows.length).to eq 1
+
+  within search_result_rows[0] do
+    element = find('a', text: 'Edit')
+
+    @subject_id = URI.decode_www_form_component(element[:href]).split('/').pop
+  end
+end
+
+Then 'the Subject is opened in the edit mode' do
+  uri = current_url.split('/')
+
+  action = uri.pop
+  subject_id = uri.pop
+
+  expect(action).to eq 'edit'
+  expect(subject_id).to eq @subject_id
+end
+
+Given 'the Subject is opened in the view mode' do
+  visit "#{STAFF_URL}/subjects/#{@subject_id}"
+end
+
+Given 'the Subject is opened in edit mode' do
+  visit "#{STAFF_URL}/subjects/#{@subject_id}/edit"
+end
+
+Given 'the Subject has one Metadata Rights Declarations' do
+  click_on 'Add Metadata Rights Declaration'
+
+  select 'This record is made available under an Universal 1.0 Public Domain Dedication Creative Commons license.', from: 'License'
+
+  click_on 'Save'
+
+  expect(find('.alert.alert-success.with-hide-alert').text).to eq 'Subject Saved'
+end
+
+Then 'the Subject does not have Metadata Rights Declarations' do
+  elements = all('#subject_metadata_rights_declarations_ li')
+
+  expect(elements.length).to eq 0
+end

staff_features/subjects/subject_edit.feature

@@ -14,20 +14,14 @@ Feature: Subject Edit
     Given the Subject is opened in edit mode
      When the user changes the '<Field>' field to '<NewValue>'
       And the user clicks on 'Save'
-     Then the 'Subject' updated message is displayed
+     Then the 'Subject' saved message is displayed
      Then the field '<Field>' has value '<NewValue>'
       Examples:
-       | Field        | NewValue          |
-       | Authority ID | Test Authority ID |
-       | Scope Note   | Test Scope Note   |
-  Scenario: Subject is not updated after changes are reverted
+       | Field        | NewValue        |
+       | Scope Note   | Test Scope Note |
+  Scenario: Subject is not updated
     Given the Subject is opened in edit mode
-     When the user changes the 'Term' field
-      And the user clicks on 'Revert Changes'
-     Then the Subject Term field has the original value
-  Scenario: Delete required sub-record of a Subject fails
-    Given the Subject is opened in edit mode
-     When the user selects 'empty Source' from 'Source' in the 'Besic Information' form
+     When the user clears 'Source' in the 'Basic Information' form
       And the user clicks on 'Save'
      Then the following error messages are displayed
        | Source - Property is required but was missing |
@@ -37,5 +31,5 @@ Feature: Subject Edit
      When the user clicks on remove icon in the 'Metadata Rights Declarations' form
       And the user clicks on 'Confirm Removal'
       And the user clicks on 'Save'
-     Then the 'Subject' updated message is displayed
+     Then the 'Subject' saved message is displayed
       And the Subject does not have Metadata Rights Declarations