Accession edit step definitions

Author: blacksmith-welder

.rubocop.yml

@@ -9,8 +9,14 @@ Metrics/AbcSize:
 Metrics/MethodLength:
   Max: 50
 
+Layout/LineLength:
+  Max: 180
+
 Layout/ElseAlignment:
   Enabled: false
 
 Style/ConditionalAssignment:
   Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false

env.rb

@@ -29,6 +29,13 @@
   Capybara::Selenium::Driver.new(app, browser: :firefox, options:)
 end
 
+Capybara.register_driver :firefox_alternative_session do |app|
+  options = Selenium::WebDriver::Firefox::Options.new
+  options.add_argument(HEADLESS)
+
+  Capybara::Selenium::Driver.new(app, browser: :firefox, options:)
+end
+
 Capybara.default_driver = :firefox
 Capybara.default_max_wait_time = 10
 

helpers/helpers.rb

@@ -67,9 +67,8 @@ def login_archivist
   end
 end
 
+# Ensure the system has at least one repository
 def ensure_test_repository_exists
-  # Ensure the system has at least one repository
-
   element = find('.alert.alert-info.with-hide-alert')
 
   if element.text == 'To create your first Repository, click the System menu above and then Manage Repositories.'
@@ -91,6 +90,23 @@ def ensure_test_repository_exists
   # Continue
 end
 
+def ensure_test_user_exists
+  visit "#{STAFF_URL}/users/new"
+
+  fill_in 'user_username_', with: 'test'
+  fill_in 'user_name_', with: 'test'
+  fill_in 'user_password_', with: 'test'
+  fill_in 'user_confirm_password_', with: 'test'
+  check 'user_is_admin_'
+
+  click_on 'Create Account', match: :first
+
+  raise 'Could not create test user' if page.has_text?('User not created') &&
+                                        !page.has_text?("Username - Username 'test' is already in use")
+
+  visit STAFF_URL
+end
+
 def find_user_table_row_in_manage_user_access_page(username)
   loop do
     begin

staff_features/accessions/accession_delete.feature

@@ -16,7 +16,7 @@ Feature: Accession Delete
      When the user clicks on 'Delete'
       And the user clicks on 'Delete' in the confirm popup
      Then the Accessions page is displayed
-      And the 'Accession deleted' message is displayed
+      And the 'Accession' deleted message is displayed
       And the Accession is deleted
   Scenario: Cancel Accession delete from the view page
     Given the user is on the Accession view page

staff_features/accessions/step_definitions/accession_delete.rb

@@ -64,7 +64,7 @@
 end
 
 Then 'the user is still on the Accession view page' do
-  expect(find('h2').text).to eq "Accession #{@uuid} Accession"
+  expect(find('h2').text).to eq "Accession Title #{@uuid} Accession"
 end
 
 Then 'the Accessions page is displayed' do

staff_features/accessions/step_definitions/accession_edit.rb

@@ -127,13 +127,14 @@
 end
 
 Given 'the Accession is opened in edit mode by User B' do
-  @session = Capybara::Session.new(:selenium)
+  @session = Capybara::Session.new(:firefox_alternative_session)
+
   @session.visit(STAFF_URL)
 
   @session.fill_in 'username', with: 'test'
   @session.fill_in 'password', with: 'test'
-
   @session.click_on 'Sign In'
+  expect(@session).to have_text 'Welcome to ArchivesSpace'
 
   @session.click_on 'Browse'
   @session.click_on 'Accessions'
@@ -169,7 +170,7 @@
     break if tries == 0
 
     begin
-      tries = tries - 1
+      tries -= 1
 
       element = @session.find('#form_messages .alert.alert-warning.update-monitor-error')
       expect(element.text).to eq 'This record is currently being edited by another user. Please contact the following users to ensure no conflicts occur: admin'

staff_features/accessions/step_definitions/accessions_search.rb

@@ -9,7 +9,7 @@
 end
 
 Then 'the Accession view page is displayed' do
-  expect(find('h2').text).to eq "Accession #{@uuid} Accession"
+  expect(find('h2').text).to eq "Accession Title #{@uuid} Accession"
 end
 
 Given 'two Accessions have been created with a common keyword in their title' do

staff_features/shared/step_definitions.rb

@@ -8,6 +8,7 @@
   login_admin
 
   ensure_test_repository_exists
+  ensure_test_user_exists
 end
 
 Given 'an archivist user is logged in' do
@@ -54,6 +55,10 @@
   expect(find('.alert.alert-success.with-hide-alert').text).to match(/^#{string}.*updated$/i)
 end
 
+Then('the {string} deleted message is displayed') do |string|
+  expect(find('.alert.alert-success.with-hide-alert').text).to match(/^#{string}.*deleted$/i)
+end
+
 Then 'the following error messages are displayed' do |messages|
   messages.raw.each do |message|
     expect(page).to have_text message[0]